Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hbase: handle partial failures in batch commit #634

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Aug 9, 2019

This may cause the data to be deleted but the index is not
deleted successfully, and unaware for the upper layer.

fix #608
Change-Id: I89c7256b627e48f4b27bc1c9f46bda001ce4908a

This may cause the data to be deleted but the index is not
deleted successfully, and unaware for the upper layer.

fix #608
Change-Id: I89c7256b627e48f4b27bc1c9f46bda001ce4908a
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #634 into master will increase coverage by 2.92%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #634      +/-   ##
============================================
+ Coverage     69.46%   72.38%   +2.92%     
- Complexity     3629     3741     +112     
============================================
  Files           218      218              
  Lines         17296    17304       +8     
  Branches       2437     2441       +4     
============================================
+ Hits          12014    12526     +512     
+ Misses         4050     3496     -554     
- Partials       1232     1282      +50
Impacted Files Coverage Δ Complexity Δ
...u/hugegraph/backend/store/hbase/HbaseSessions.java 67.29% <33.33%> (+67.29%) 24 <0> (+24) ⬆️
...hugegraph/backend/serializer/BinarySerializer.java 81.16% <0%> (+0.17%) 99% <0%> (ø) ⬇️
...va/com/baidu/hugegraph/backend/cache/RamCache.java 72.54% <0%> (+0.39%) 45% <0%> (+1%) ⬆️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 80.72% <0%> (+0.41%) 166% <0%> (ø) ⬇️
...a/com/baidu/hugegraph/backend/query/Condition.java 69.44% <0%> (+0.46%) 25% <0%> (ø) ⬇️
...du/hugegraph/backend/store/BackendSessionPool.java 82.14% <0%> (+5.35%) 15% <0%> (+1%) ⬆️
...om/baidu/hugegraph/backend/store/BackendTable.java 92% <0%> (+6%) 12% <0%> (ø) ⬇️
...aidu/hugegraph/backend/store/hbase/HbaseStore.java 78.04% <0%> (+78.04%) 29% <0%> (+29%) ⬆️
...u/hugegraph/backend/store/hbase/HbaseFeatures.java 82.35% <0%> (+82.35%) 14% <0%> (+14%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f361a...5e912a3. Read the comment docs.

@Linary Linary merged commit 214ef8b into master Aug 15, 2019
@Linary Linary deleted the hbase-commit-improve branch August 15, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于gremlin设置limit后结果不正确问题
3 participants