support unique index #636
Merged
support unique index #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
requested changes
Aug 12, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/IndexType.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendMutation.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java
Show resolved
Hide resolved
...aph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTables.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
============================================
+ Coverage 72.17% 72.35% +0.18%
- Complexity 3740 3780 +40
============================================
Files 218 218
Lines 17334 17420 +86
Branches 2447 2462 +15
============================================
+ Hits 12510 12604 +94
+ Misses 3530 3521 -9
- Partials 1294 1295 +1
Continue to review full report at Codecov.
|
javeme
requested changes
Aug 14, 2019
...aph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTables.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java
Outdated
Show resolved
Hide resolved
javeme
requested changes
Aug 14, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java
Show resolved
Hide resolved
| query.eq(HugeKeys.INDEX_LABEL_ID, indexLabel.id()); | ||
| query.eq(HugeKeys.FIELD_VALUES, value); | ||
| query.limit(1L); | ||
| return this.query(query).hasNext(); |
There was a problem hiding this comment.
LOG.warn for results size > 1
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
| query.limit(1L); | ||
| return this.query(query).hasNext(); | ||
| } | ||
|
|
There was a problem hiding this comment.
move to private methods block
| value = INDEX_EMPTY_SYM; | ||
| } | ||
| Id id = element.id(); | ||
| if (!removed && this.existUniqueValue(indexLabel, value, id)) { |
There was a problem hiding this comment.
TODO: add lock for updating unique index
| allPropValues.add(property.value()); | ||
| } | ||
| if (!hasNull) { | ||
| firstNullField++; |
There was a problem hiding this comment.
if(firstNullField == -1) firstNullField = allPropValues.size()
javeme
reviewed
Aug 17, 2019
| /* | ||
| * If existed label is prefix of new created label, | ||
| * remove the existed label. | ||
| */ |
There was a problem hiding this comment.
not adaptable for unique index
implemented: #633 Change-Id: I753a81d0d47b0d7979563d5a9f41d368e06a5b33
Change-Id: Iefb72b889fbf81e4d7b048ec9bca5dcf8b91c81d
Change-Id: If7c96c79b74ca21f5e26dd399c275bbed3f88081
Change-Id: I59379d25b1f3934abcb0ddd10c7cc5e3114207a8
javeme
reviewed
Aug 19, 2019
| /* | ||
| * If existed label is prefix of new created label, | ||
| * remove the existed label. | ||
| */ |
| if (entry.type().isUniqueIndex() && | ||
| originAction == Action.APPEND) { | ||
| throw new IllegalArgumentException(String.format( | ||
| "Unique constraint conflict is found in tx " + |
| "fields %s of existed index label '%s'", | ||
| newFields, this.name, oldFields, old.name()); | ||
| E.checkArgument(!predicate.test(newFields, oldFields), | ||
| "Repeat new index label %s(%s) with fields %s " + |
Change-Id: I84520193a196ad586487bd05a96495c86c030ff0
javeme
approved these changes
Aug 19, 2019
Linary
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented: #633
Change-Id: I753a81d0d47b0d7979563d5a9f41d368e06a5b33