Upgrade tinkerpop version to 3.4.3 #648

Linary · 2019-08-14T10:39:54Z

Change-Id: I5443b6a05eea74205a373f093dad27536e04f0be

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/ContextGremlinServer.java

hugegraph-core/src/main/java/com/baidu/hugegraph/plugin/HugeGraphGremlinPlugin.java

hugegraph-dist/src/assembly/static/conf/gremlin-server.yaml

Linary · 2019-08-20T02:47:42Z

public void shouldConstructDetachedEdge() {
        g.E(convertToEdgeId("marko", "knows", "vadas")).next().property("year", 2002);
        final DetachedEdge detachedEdge = DetachedFactory.detach(g.E(convertToEdgeId("marko", "knows", "vadas")).next(), true);
...

com.baidu.hugegraph.backend.BackendException: Can't do index query when there are changes in transaction

	at com.baidu.hugegraph.backend.tx.GraphIndexTransaction.queryIndex(GraphIndexTransaction.java:331)
	at com.baidu.hugegraph.backend.tx.GraphTransaction.indexQuery(GraphTransaction.java:1044)
	at com.baidu.hugegraph.backend.tx.GraphTransaction.query(GraphTransaction.java:330)
	at com.baidu.hugegraph.backend.tx.GraphTransaction.queryVerticesFromBackend(GraphTransaction.java:513)
	at com.baidu.hugegraph.backend.cache.CachedGraphTransaction.queryVerticesFromBackend(CachedGraphTransaction.java:150)
	at com.baidu.hugegraph.backend.tx.GraphTransaction.queryVertices(GraphTransaction.java:482)
	at com.baidu.hugegraph.HugeGraph.vertices(HugeGraph.java:390)
	at com.baidu.hugegraph.traversal.optimize.HugeGraphStep.vertices(HugeGraphStep.java:94)
	at com.baidu.hugegraph.traversal.optimize.HugeGraphStep.lambda$new$0(HugeGraphStep.java:66)
	at org.apache.tinkerpop.gremlin.process.traversal.step.map.GraphStep.processNextStart(GraphStep.java:155)
	at org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.hasNext(AbstractStep.java:143)

Linary · 2019-08-20T09:08:43Z

org.apache.tinkerpop.shaded.jackson.core.JsonGenerationException: Can not write a field name, expecting a value

	at org.apache.tinkerpop.shaded.jackson.core.JsonGenerator._reportError(JsonGenerator.java:1961)
	at org.apache.tinkerpop.shaded.jackson.core.json.UTF8JsonGenerator.writeFieldName(UTF8JsonGenerator.java:188)
	at org.apache.tinkerpop.shaded.jackson.core.json.JsonGeneratorImpl.writeStringField(JsonGeneratorImpl.java:202)
	at org.apache.tinkerpop.gremlin.structure.util.star.StarGraphGraphSONSerializerV1d0.ser(StarGraphGraphSONSerializerV1d0.java:77)
	at org.apache.tinkerpop.gremlin.structure.util.star.StarGraphGraphSONSerializerV1d0.serializeWithType(StarGraphGraphSONSerializerV1d0.java:67)
	at org.apache.tinkerpop.gremlin.structure.util.star.StarGraphGraphSONSerializerV1d0.serializeWithType(StarGraphGraphSONSerializerV1d0.java:50)
	at org.apache.tinkerpop.shaded.jackson.databind.ser.impl.TypeWrappedSerializer.serialize(TypeWrappedSerializer.java:32)
	at org.apache.tinkerpop.shaded.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:480)
	at org.apache.tinkerpop.shaded.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:319)
	at org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:3906)
	at org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper.writeValue(ObjectMapper.java:3177)
	at org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONWriter.writeVertex(GraphSONWriter.java:82)
	at org.apache.tinkerpop.gremlin.structure.io.IoVertexTest.shouldReadWriteVertexWithBOTHEdges(IoVertexTest.java:129)

Linary · 2019-08-27T10:10:14Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeEdge.java

hugegraph-test/src/main/java/com/baidu/hugegraph/tinkerpop/TestGraph.java

hugegraph-test/src/main/java/com/baidu/hugegraph/tinkerpop/TestGraphProvider.java

javeme · 2019-08-27T11:52:09Z

hugegraph-test/src/main/resources/fast-methods.filter

@@ -143,6 +143,13 @@ org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasTest.Traversals.g_
 org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasTest.Traversals.g_V_hasXage_withoutX27_29X_count: Unsupported relation 'NEQ'
 org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasTest.Traversals.g_V_hasXname_gtXmX_andXcontainingXoXXX: Unsupported predicate 'containing(o)'

+# Unsupport edge label 'created': 'software' -> 'person'
+org.apache.tinkerpop.gremlin.process.traversal.step.map.AddEdgeTest.Traversals.g_V_hasXname_markoX_asXaX_outEXcreatedX_asXbX_inV_addEXselectXbX_labelX_toXaX: Unsupport edge from inV to outV


can we make an edge label for it

seems no way, there is existed an edgelabel (created: person -> software) in this case

codecov · 2019-08-30T09:49:58Z

Codecov Report

Merging #648 into master will decrease coverage by 0.05%.
The diff coverage is 73.72%.

@@             Coverage Diff              @@
##             master     #648      +/-   ##
============================================
- Coverage        73%   72.94%   -0.06%     
- Complexity     3944     3983      +39     
============================================
  Files           219      220       +1     
  Lines         17850    17863      +13     
  Branches       2567     2559       -8     
============================================
- Hits          13031    13030       -1     
- Misses         3479     3496      +17     
+ Partials       1340     1337       -3

Impacted Files	Coverage Δ	Complexity Δ
...aidu/hugegraph/backend/page/PageEntryIterator.java	`83.72% <ø> (ø)`	`17 <0> (ø)`	⬇️
...aidu/hugegraph/backend/tx/AbstractTransaction.java	`68.11% <ø> (-5.91%)`	`37 <0> (ø)`
.../java/com/baidu/hugegraph/version/CoreVersion.java	`80% <ø> (ø)`	`2 <0> (ø)`	⬇️
...u/hugegraph/backend/tx/SchemaIndexTransaction.java	`82.05% <ø> (ø)`	`12 <0> (ø)`	⬇️
...va/com/baidu/hugegraph/structure/HugeFeatures.java	`27.71% <ø> (+0.32%)`	`2 <0> (ø)`	⬇️
...c/main/java/com/baidu/hugegraph/util/DateUtil.java	`53.84% <0%> (-2.16%)`	`6 <0> (ø)`
...java/com/baidu/hugegraph/dist/HugeGraphServer.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...baidu/hugegraph/plugin/HugeGraphGremlinPlugin.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...va/com/baidu/hugegraph/backend/page/QueryList.java	`77.98% <100%> (ø)`	`16 <0> (ø)`	⬇️
...hugegraph/backend/query/ConditionQueryFlatten.java	`74.45% <100%> (ø)`	`71 <0> (ø)`	⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47f309...b5339b1. Read the comment docs.

hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/Directions.java

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/ContextGremlinServer.java

hugegraph-test/src/main/resources/fast-methods.filter

javeme · 2019-09-04T06:42:39Z

hugegraph-test/pom.xml

-                                <include>**/ProcessPerformanceTest.java</include>
-                            </includes>
-                        </configuration>
-                    </execution>


update jenkins and travis reference

travis doesn't have perf test

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/HugeGraphStep.java

hugegraph-test/src/main/resources/fast-methods.filter

hugegraph-test/src/main/resources/methods.filter

Change-Id: I5443b6a05eea74205a373f093dad27536e04f0be

Change-Id: I01fb398ecce207d01ec44f37f3aa21d122ef715f

Change-Id: I3613ae3d0bf15bd8f0897f3661018911b03edfb2

Change-Id: I531184f6e2c26b6fcd76037ad72551bde5079688

Change-Id: I762be56a3dea63f0b26c654ed0da7f6da726b717

Change-Id: Id789ef91e3d5121f3f5f3cbf6f63cab663a81a04

Change-Id: I8258657873e8825e74042123fe91a81e1a8e8027

Change-Id: I3bf2914dc69a6ef46c2f1a2f025210b76b913511

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/QueryHolder.java

Change-Id: I2f4a9198f801713f08b776b91e535d474329d455

javeme · 2019-09-11T06:05:17Z

pom.xml

@@ -205,7 +205,7 @@
            <dependency>
                <groupId>org.apache.tinkerpop</groupId>
                <artifactId>gremlin-groovy-test</artifactId>
-                <version>${tinkerpop.version}</version>
+                <version>3.2.11</version>


keep ${tinkerpop.version}

gremlin-groovy-test the newest version is 3.2.11

Change-Id: I0cd5ebcad64fa9157c05c08b888b6ff4700352e4

javeme · 2019-09-12T05:57:34Z

hugegraph-test/pom.xml

@@ -136,6 +133,8 @@
                    <execution>
                        <id>tinkerpop-process-test</id>
                        <configuration>
+                            <!-- ReadTest.Traversals.class need it -->


seems should remove tinkerpop-process-test

Change-Id: I44a4c99876891edb2dcef151cf06872ce975bca9

hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/Directions.java

hugegraph-dist/src/assembly/static/scripts/empty-sample.groovy

Change-Id: Ib28d52a1f5fef7a9059b122ff2383d5a5b1709c1

Linary force-pushed the upgrade-tinkerpop-version branch 3 times, most recently from 1fa89a3 to b96cc59 Compare August 15, 2019 07:33

javeme requested changes Aug 15, 2019

View reviewed changes

Linary force-pushed the upgrade-tinkerpop-version branch 4 times, most recently from 305c8bd to 8ba4a77 Compare August 27, 2019 10:10

Linary force-pushed the upgrade-tinkerpop-version branch 2 times, most recently from d47d21d to 9a465ba Compare August 27, 2019 10:57

javeme requested changes Aug 27, 2019

View reviewed changes

Linary force-pushed the upgrade-tinkerpop-version branch 4 times, most recently from a68e207 to e6e48ee Compare August 30, 2019 09:38

Linary force-pushed the upgrade-tinkerpop-version branch from e6e48ee to 903a8bc Compare August 30, 2019 11:56

javeme requested changes Sep 2, 2019

View reviewed changes

javeme reviewed Sep 4, 2019

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/HugeGraphStep.java Show resolved Hide resolved

hugegraph-test/src/main/resources/fast-methods.filter Outdated Show resolved Hide resolved

hugegraph-test/src/main/resources/methods.filter Outdated Show resolved Hide resolved

Linary force-pushed the upgrade-tinkerpop-version branch 4 times, most recently from 6e5a921 to 0517555 Compare September 11, 2019 02:21

Linary added 3 commits September 11, 2019 11:20

Upgrade tinkerpop version to 3.4.3

500a338

Change-Id: I5443b6a05eea74205a373f093dad27536e04f0be

some improve

b1c6240

Change-Id: I01fb398ecce207d01ec44f37f3aa21d122ef715f

fix some bugs find by structure and process test

1952cbe

Change-Id: I3613ae3d0bf15bd8f0897f3661018911b03edfb2

Linary added 5 commits September 11, 2019 11:20

tiny improve

1b7ae61

Change-Id: I531184f6e2c26b6fcd76037ad72551bde5079688

tiny improve

1c99b1b

Change-Id: I762be56a3dea63f0b26c654ed0da7f6da726b717

improve some reason

5e46230

Change-Id: Id789ef91e3d5121f3f5f3cbf6f63cab663a81a04

remove deprecated performance test

d9ca352

Change-Id: I8258657873e8825e74042123fe91a81e1a8e8027

upgrade version and add test

5106678

Change-Id: I3bf2914dc69a6ef46c2f1a2f025210b76b913511

javeme requested changes Sep 11, 2019

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/QueryHolder.java Outdated Show resolved Hide resolved

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/QueryHolder.java Outdated Show resolved Hide resolved

move QueryResults to public package

1c83b1d

Change-Id: I2f4a9198f801713f08b776b91e535d474329d455

Linary force-pushed the upgrade-tinkerpop-version branch from 0517555 to 1c83b1d Compare September 11, 2019 03:40

javeme reviewed Sep 11, 2019

View reviewed changes

fix codedov 0%

1df0602

Change-Id: I0cd5ebcad64fa9157c05c08b888b6ff4700352e4

javeme requested changes Sep 12, 2019

View reviewed changes

improve comment

331582d

Change-Id: I44a4c99876891edb2dcef151cf06872ce975bca9

javeme previously approved these changes Sep 12, 2019

View reviewed changes

zhoney requested changes Sep 12, 2019

View reviewed changes

hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/Directions.java Outdated Show resolved Hide resolved

hugegraph-dist/src/assembly/static/scripts/empty-sample.groovy Outdated Show resolved Hide resolved

tiny improve

b5339b1

Change-Id: Ib28d52a1f5fef7a9059b122ff2383d5a5b1709c1

Linary dismissed javeme’s stale review via b5339b1 September 12, 2019 08:34

zhoney approved these changes Sep 12, 2019

View reviewed changes

javeme approved these changes Sep 12, 2019

View reviewed changes

javeme merged commit 1c062b8 into master Sep 12, 2019

javeme deleted the upgrade-tinkerpop-version branch September 12, 2019 11:04

Linary mentioned this pull request Oct 21, 2019

Put some unsolvable tests into methods filter #714

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade tinkerpop version to 3.4.3 #648

Upgrade tinkerpop version to 3.4.3 #648

Linary commented Aug 14, 2019

Linary commented Aug 20, 2019

Linary commented Aug 20, 2019

Linary commented Aug 27, 2019

javeme Aug 27, 2019

Linary Aug 28, 2019 •

edited

codecov bot commented Aug 30, 2019 •

edited

javeme Sep 4, 2019

Linary Sep 4, 2019

javeme Sep 11, 2019

Linary Sep 11, 2019

javeme Sep 12, 2019

Upgrade tinkerpop version to 3.4.3 #648

Upgrade tinkerpop version to 3.4.3 #648

Conversation

Linary commented Aug 14, 2019

Linary commented Aug 20, 2019

Linary commented Aug 20, 2019

Linary commented Aug 27, 2019

javeme Aug 27, 2019

Choose a reason for hiding this comment

Linary Aug 28, 2019 • edited

Choose a reason for hiding this comment

codecov bot commented Aug 30, 2019 • edited

Codecov Report

javeme Sep 4, 2019

Choose a reason for hiding this comment

Linary Sep 4, 2019

Choose a reason for hiding this comment

javeme Sep 11, 2019

Choose a reason for hiding this comment

Linary Sep 11, 2019

Choose a reason for hiding this comment

javeme Sep 12, 2019

Choose a reason for hiding this comment

Linary Aug 28, 2019 •

edited

codecov bot commented Aug 30, 2019 •

edited