Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: left index of system type can't be deleted #675

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Aug 31, 2019

Change-Id: I654b2e4c69f8aebfc7ebed3225b2dd09da1720a0

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #675 into master will decrease coverage by 0.05%.
The diff coverage is 46.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #675      +/-   ##
============================================
- Coverage        73%   72.94%   -0.06%     
  Complexity     3944     3944              
============================================
  Files           219      219              
  Lines         17850    17867      +17     
  Branches       2567     2569       +2     
============================================
+ Hits          13031    13033       +2     
- Misses         3479     3492      +13     
- Partials       1340     1342       +2
Impacted Files Coverage Δ Complexity Δ
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 79.66% <ø> (+0.44%) 37 <0> (ø) ⬇️
...ugegraph/backend/store/memory/InMemoryDBStore.java 85.15% <ø> (+0.66%) 24 <0> (ø) ⬇️
...egraph/backend/store/cassandra/CassandraStore.java 69.4% <ø> (+0.25%) 48 <0> (ø) ⬇️
...java/com/baidu/hugegraph/schema/SchemaElement.java 76.92% <0%> (-3.08%) 21 <1> (+1)
.../hugegraph/backend/store/AbstractBackendStore.java 71.42% <0%> (-5.5%) 3 <0> (ø)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 71.55% <42.85%> (-1.89%) 67 <1> (+1)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 80.31% <85.71%> (-0.06%) 176 <1> (ø)
...du/hugegraph/backend/store/BackendSessionPool.java 75.8% <0%> (-8.07%) 15% <0%> (-2%)
...a/com/baidu/hugegraph/backend/query/Condition.java 77.59% <0%> (+0.41%) 31% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47f309...d8b4494. Read the comment docs.

this.checkGraphNotClosed();
/*
* NOTE: each system operation will be auto committed,
* Don't need to open tinkerpop tx by readWrite() and commit manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the comment and the code have some inconsistencies?

this.tx.readWrite();

Change-Id: I654b2e4c69f8aebfc7ebed3225b2dd09da1720a0
Change-Id: I6380f86ba32f691cb393239d97fc0093650a29b8
Linary
Linary previously approved these changes Sep 10, 2019
Change-Id: Ifbfcb0da962370b99378fde2aa33073df77f12a7
@javeme javeme merged commit 64f9409 into master Sep 11, 2019
@javeme javeme deleted the sys-left-index-bug branch September 11, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants