fix bug update property to value of removed element with unique index #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: #678 Change-Id: I0aeb3603078fdc07af668cf0c65c3edbc28e8814
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
============================================
+ Coverage 72.94% 72.94% +<.01%
- Complexity 3919 3925 +6
============================================
Files 218 218
Lines 17688 17716 +28
Branches 2533 2541 +8
============================================
+ Hits 12902 12923 +21
Misses 3468 3468
- Partials 1318 1325 +7
Continue to review full report at Codecov.
|
javeme
requested changes
Sep 2, 2019
| private Set<HugeProperty<?>> updatedOldestProps; // Oldest props | ||
|
|
||
| private Set<HugeProperty<?>> addedProps; | ||
| private Set<HugeProperty<?>> removedProps; |
| // Override vertex | ||
| this.addVertex(vertex); | ||
| } | ||
| this.propertyUpdated(vertex, prop, vertex.setProperty(prop)); |
There was a problem hiding this comment.
update comment, same as others
Change-Id: I7d99ae8d137d0286c6a5d6f5e1902bc86b48dab5
javeme
requested changes
Sep 2, 2019
| @@ -99,15 +99,14 @@ | |||
|
|
|||
| private Map<Id, HugeEdge> addedEdges; | |||
| private Map<Id, HugeEdge> removedEdges; | |||
| private Set<HugeProperty<?>> addedProps; | |||
Change-Id: I8569fa6aea9899d2152728c65c7bdc5adb6bed68
javeme
approved these changes
Sep 2, 2019
Linary
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #678
Change-Id: I0aeb3603078fdc07af668cf0c65c3edbc28e8814