Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support bin serialization for cassandra #680

Merged
merged 7 commits into from
Sep 17, 2019
Merged

support bin serialization for cassandra #680

merged 7 commits into from
Sep 17, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Sep 3, 2019

Change-Id: I5931227ae45a28f5d0d07129beaa9620d7fc8c6d

@javeme
Copy link
Contributor Author

javeme commented Sep 13, 2019

commit before rebase hugegraph@693c475

@javeme
support bin serialization for cassandra
1637797 
Change-Id: I5931227ae45a28f5d0d07129beaa9620d7fc8c6d
@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited

Codecov Report

Merging #680 into master will increase coverage by 1.22%.
The diff coverage is 93.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #680      +/-   ##
============================================
+ Coverage     72.89%   74.11%   +1.22%     
- Complexity     3987     4072      +85     
============================================
  Files           220      220              
  Lines         17905    17917      +12     
  Branches       2561     2571      +10     
============================================
+ Hits          13051    13280     +229     
+ Misses         3510     3278     -232     
- Partials       1344     1359      +15
Impacted Files Coverage Δ Complexity Δ
...backend/store/postgresql/PostgresqlSerializer.java 84.61% <ø> (-2.89%) 4 <0> (-2)
...backend/store/cassandra/CassandraBackendEntry.java 75% <ø> (+22.05%) 3 <0> (-1) ⬇️
...gegraph/backend/store/mysql/MysqlBackendEntry.java 75% <ø> (+22.05%) 3 <0> (-1) ⬇️
...java/com/baidu/hugegraph/type/define/DataType.java 82.66% <0%> (-4.66%) 36 <0> (ø)
...egraph/backend/store/cassandra/CassandraTable.java 76.35% <0%> (-4.97%) 71 <0> (-4)
...kend/store/postgresql/PostgresqlStoreProvider.java 92.1% <100%> (ø) 5 <1> (ø) ⬇️
...h/backend/store/postgresql/PostgresqlSessions.java 70.27% <100%> (ø) 8 <0> (ø) ⬇️
...hugegraph/backend/serializer/BinarySerializer.java 83.36% <100%> (+2.98%) 104 <2> (+1) ⬆️
...c/main/java/com/baidu/hugegraph/backend/id/Id.java 95% <100%> (+0.26%) 8 <2> (+2) ⬆️
...ugegraph/backend/serializer/TableBackendEntry.java 93.5% <100%> (+43.5%) 27 <6> (+14) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1208522...9e4a6bc. Read the comment docs.

@javeme javeme force-pushed the cassandra-bin-ser branch 4 times, most recently from 7f3087a to ded2f24 Compare September 13, 2019 15:39
@javeme
fix escapeString
2348a72 
Change-Id: Iae56068ba5cfd6e7ce20ea5b149bec69c9ba6ba3
@javeme javeme force-pushed the cassandra-bin-ser branch 3 times, most recently from e4c5f96 to 12295c1 Compare September 14, 2019 04:38
@javeme
improve unit test
63a531e 
Change-Id: Ie03587fc7550c4ce629619688287a27299f96ba4
@javeme javeme force-pushed the cassandra-bin-ser branch 4 times, most recently from 2eceec3 to c27b151 Compare September 14, 2019 14:30
@javeme
add unit test for serializer
52c786b 
Change-Id: I72197662ff6903a91426e5166d8aa9a56b7e84e0
@javeme
add test for BinaryInlineSerializer
4c483ac 
Change-Id: I3b7031f394913a852044650bc1ab3c4f24ba04ee
Linary
Linary requested changes Sep 15, 2019
View reviewed changes
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/TableBackendEntry.java
@@ -82,11 +84,15 @@ public Id id() {
this.column(key, value);
break;
case SET:
this.columns.putIfAbsent(key, new LinkedHashSet<>());
if (!this.columns.containsKey(key)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment

...cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraSerializer.java

@Override
protected Object writeProperty(Object value) {
PropertyKey pkey = new PropertyKey(null, IdGenerator.of(0L), "fake");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment

@javeme
tiny fix
874d6da 
Change-Id: Id6428ef3e7358b816834efe652147bc5a96be97f
Linary
Linary previously approved these changes Sep 15, 2019
View reviewed changes
zhoney
zhoney requested changes Sep 15, 2019
View reviewed changes
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/TableSerializer.java Outdated
}

protected void parseProperty(Id key, String colValue, HugeElement owner) {
protected void parseProperty(Id key, Object colValue, HugeElement owner) {
// Get PropertyKey by PropertyKey name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Get PropertyKey by PropertyKey id

...ssandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraBackendEntry.java
@@ -19,11 +19,8 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade backend version

@javeme
upgrade backend version
9e4a6bc 
Change-Id: Ib4f48f3235ac9e5526c63c5617e3819ab4d29711
@Linary Linary merged commit efcd839 into master Sep 17, 2019
@Linary Linary deleted the cassandra-bin-ser branch September 17, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linary Linary Linary approved these changes

@zhoney zhoney zhoney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javeme @Linary @zhoney