Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support paging for tasks API #720

Merged
merged 2 commits into from
Nov 4, 2019
Merged

support paging for tasks API #720

merged 2 commits into from
Nov 4, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Oct 25, 2019

Change-Id: Ie036d433ef74d7c6724bf869425c3fd528f08941
related: #718

@javeme
Copy link
Contributor Author

javeme commented Oct 25, 2019

Do not upgrade the api version because all client components need to be updated, and it's compatible to add a query param.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #720 into master will decrease coverage by 0.01%.
The diff coverage is 55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #720      +/-   ##
============================================
- Coverage     71.41%   71.39%   -0.02%     
+ Complexity     4328     4327       -1     
============================================
  Files           280      280              
  Lines         20593    20609      +16     
  Branches       2893     2902       +9     
============================================
+ Hits          14706    14714       +8     
- Misses         4444     4446       +2     
- Partials       1443     1449       +6
Impacted Files Coverage Δ Complexity Δ
...ava/com/baidu/hugegraph/backend/page/PageInfo.java 86.36% <ø> (+1.91%) 13 <0> (-1) ⬇️
...aidu/hugegraph/backend/page/PageEntryIterator.java 83.72% <100%> (ø) 17 <0> (ø) ⬇️
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 70.38% <53.33%> (-1.11%) 44 <6> (+1)
...main/java/com/baidu/hugegraph/api/job/TaskAPI.java 43.47% <55.55%> (-3.34%) 0 <0> (ø)
...va/com/baidu/hugegraph/backend/cache/RamCache.java 73.33% <0%> (-0.4%) 50% <0%> (-1%)
...a/com/baidu/hugegraph/backend/query/Condition.java 78% <0%> (+0.41%) 31% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2785a09...626918d. Read the comment docs.

Change-Id: Ie036d433ef74d7c6724bf869425c3fd528f08941
related: #718
Change-Id: I78ab85e6a79698ab795c03f88cf55ae1f1f3d7aa
@javeme javeme merged commit 95eba35 into master Nov 4, 2019
@javeme javeme deleted the tasks-paging branch November 4, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants