Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RocksDB from v5.17.2 to v6.3.6 #722

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Oct 29, 2019

also upgraded deprecated options like max_background_jobs

and add some options:

  • max_total_wal_size
  • db_write_buffer_size
  • delete_obsolete_files_period

related: #714
Change-Id: I693a8d4550110280c46f0c40da6b4e42ad540eb3

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #722 into master will increase coverage by 0.6%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #722     +/-   ##
===========================================
+ Coverage     70.72%   71.32%   +0.6%     
- Complexity     4321     4345     +24     
===========================================
  Files           281      281             
  Lines         20753    20762      +9     
  Branches       2925     2926      +1     
===========================================
+ Hits          14677    14808    +131     
+ Misses         4627     4503    -124     
- Partials       1449     1451      +2
Impacted Files Coverage Δ Complexity Δ
...h/backend/store/rocksdbsst/RocksDBSstSessions.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ugegraph/backend/store/rocksdb/RocksDBOptions.java 99.14% <100%> (+0.04%) 2 <0> (ø) ⬇️
...raph/backend/store/rocksdb/RocksDBStdSessions.java 69.9% <93.33%> (+0.22%) 29 <0> (+1) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 77.59% <0%> (-0.83%) 31% <0%> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 80.97% <0%> (+0.39%) 179% <0%> (ø) ⬇️
...baidu/hugegraph/backend/store/mysql/MysqlUtil.java 96.61% <0%> (+3.38%) 23% <0%> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 81.85% <0%> (+8.54%) 72% <0%> (+10%) ⬆️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 62.94% <0%> (+10.65%) 19% <0%> (+8%) ⬆️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 89.01% <0%> (+14.01%) 1% <0%> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 75.54% <0%> (+17.93%) 37% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee971f...affa3d8. Read the comment docs.

@javeme javeme force-pushed the rocksdb_options_upgrade_6.3 branch 2 times, most recently from 37b2dc9 to 7f28005 Compare November 4, 2019 13:16
also upgraded deprecated options like: max_background_jobs

and add some options:
 * max_total_wal_size
 * db_write_buffer_size
 * delete_obsolete_files_period

related: #714
Change-Id: I693a8d4550110280c46f0c40da6b4e42ad540eb3
@javeme javeme force-pushed the rocksdb_options_upgrade_6.3 branch from 7f28005 to affa3d8 Compare November 4, 2019 15:15
@Linary Linary merged commit ec88b56 into master Nov 6, 2019
@Linary Linary deleted the rocksdb_options_upgrade_6.3 branch November 6, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants