fix mistake multiple backend info as no backend info #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoney
force-pushed
the
multi-backend-info
branch
from
33c1772
to
ee40d99
Compare
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
============================================
+ Coverage 71.12% 71.13% +<.01%
- Complexity 4330 4332 +2
============================================
Files 281 281
Lines 20693 20703 +10
Branches 2919 2921 +2
============================================
+ Hits 14718 14727 +9
+ Misses 4527 4526 -1
- Partials 1448 1450 +2
Continue to review full report at Codecov.
|
zhoney
force-pushed
the
multi-backend-info
branch
2 times, most recently
from
a5f578c
to
edc3950
Compare
Linary
previously approved these changes
Oct 31, 2019
javeme
reviewed
Nov 3, 2019
| @@ -67,9 +71,19 @@ public void init() { | |||
| PropertyKey pkey = null; | |||
| try { | |||
| pkey = schema.getPropertyKey(PK_BACKEND_INFO); | |||
| } catch (BackendException | IllegalStateException | | |||
| UncheckedIOException ignored) { | |||
| } catch (BackendException | UncheckedIOException ignored) { | |||
There was a problem hiding this comment.
please rebase https://github.com/hugegraph/hugegraph/pull/708
Change-Id: I4f017d7763698c7ccd01eb3b98f0fe897d8448c4
zhoney
force-pushed
the
multi-backend-info
branch
from
edc3950
to
9b45d0e
Compare
javeme
requested changes
Nov 4, 2019
| this.graph.name(), | ||
| this.graph.backend()); | ||
| } | ||
| // ignore |
There was a problem hiding this comment.
expect throw e here, since we assume the backend is inited before calling info()
javeme
approved these changes
Nov 4, 2019
Linary
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I4f017d7763698c7ccd01eb3b98f0fe897d8448c4