Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix task result is null even it is COMPLETED #732

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Nov 4, 2019

task result is not set when set status=FAILED/SUCCESS

fix: #731
Change-Id: I2b572f35faffd27680e04dfa28c4696318765c77

task result is not set when set status=FAILED/SUCCESS

fix: #731
Change-Id: I2b572f35faffd27680e04dfa28c4696318765c77
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #732 into master will increase coverage by 0.58%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #732      +/-   ##
===========================================
+ Coverage     70.72%   71.3%   +0.58%     
- Complexity     4321    4343      +22     
===========================================
  Files           281     281              
  Lines         20753   20753              
  Branches       2925    2924       -1     
===========================================
+ Hits          14677   14798     +121     
+ Misses         4627    4506     -121     
  Partials       1449    1449
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 65.06% <100%> (ø) 47 <0> (-1) ⬇️
...baidu/hugegraph/backend/store/mysql/MysqlUtil.java 96.61% <0%> (+3.38%) 23% <0%> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 81.85% <0%> (+8.54%) 72% <0%> (+10%) ⬆️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 62.94% <0%> (+10.65%) 19% <0%> (+8%) ⬆️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 89.01% <0%> (+14.01%) 1% <0%> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 75.54% <0%> (+17.93%) 37% <0%> (+1%) ⬆️
...egraph/backend/store/mysql/MysqlStoreProvider.java 91.66% <0%> (+33.33%) 7% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee971f...73498ee. Read the comment docs.

@zhoney zhoney merged commit 712c313 into master Nov 5, 2019
@zhoney zhoney deleted the fix-task-result-null-after-complete branch November 5, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task result is null even it is COMPLETED
3 participants