-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay checking for vertex non-nullable properties #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
force-pushed
the
set-property-with-cardinality
branch
from
November 20, 2019 13:09
f00b42e
to
aa5d2f0
Compare
javeme
reviewed
Nov 20, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
============================================
+ Coverage 71.49% 71.62% +0.12%
- Complexity 4362 4368 +6
============================================
Files 282 282
Lines 20885 20896 +11
Branches 2948 2950 +2
============================================
+ Hits 14932 14967 +35
+ Misses 4485 4453 -32
- Partials 1468 1476 +8
Continue to review full report at Codecov.
|
fix #751 |
Add tests for addV() with property(single/list/set) |
fix #751 Change-Id: I0f818d51ca45f167df1f01ab6e6632f76f2e50fe
Change-Id: If787be79bec7a94f5142196e523127f2a9a7439b
Linary
force-pushed
the
set-property-with-cardinality
branch
from
December 13, 2019 02:56
004e20d
to
8e615dc
Compare
javeme
previously approved these changes
Dec 17, 2019
Change-Id: I2856980df7e78ca8b65232b53c4366fe23eb4ee0
Linary
force-pushed
the
set-property-with-cardinality
branch
from
December 18, 2019 09:23
f11a617
to
319e629
Compare
zhoney
approved these changes
Dec 18, 2019
javeme
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.