Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay checking for vertex non-nullable properties #756

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Nov 20, 2019

No description provided.

@Linary Linary force-pushed the set-property-with-cardinality branch from f00b42e to aa5d2f0 Compare November 20, 2019 13:09
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #756 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #756      +/-   ##
============================================
+ Coverage     71.49%   71.62%   +0.12%     
- Complexity     4362     4368       +6     
============================================
  Files           282      282              
  Lines         20885    20896      +11     
  Branches       2948     2950       +2     
============================================
+ Hits          14932    14967      +35     
+ Misses         4485     4453      -32     
- Partials       1468     1476       +8
Impacted Files Coverage Δ Complexity Δ
...a/com/baidu/hugegraph/type/define/Cardinality.java 75% <ø> (-11.67%) 7 <0> (+2)
...java/com/baidu/hugegraph/structure/HugeVertex.java 78.69% <100%> (+0.37%) 75 <0> (+3) ⬆️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 81.68% <100%> (+0.04%) 232 <2> (ø) ⬇️
...a/com/baidu/hugegraph/backend/query/Condition.java 78% <0%> (-0.42%) 31% <0%> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 80.58% <0%> (-0.4%) 179% <0%> (ø)
...com/baidu/hugegraph/api/schema/VertexLabelAPI.java 65.07% <0%> (+3.17%) 0% <0%> (ø) ⬇️
...aidu/hugegraph/api/filter/CompressInterceptor.java 73.07% <0%> (+3.84%) 0% <0%> (ø) ⬇️
...api/src/main/java/com/baidu/hugegraph/api/API.java 58.62% <0%> (+8.04%) 0% <0%> (ø) ⬇️
...va/com/baidu/hugegraph/api/gremlin/GremlinAPI.java 73.58% <0%> (+11.32%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1774242...319e629. Read the comment docs.

@Linary
Copy link
Contributor Author

Linary commented Nov 21, 2019

fix #751

@javeme
Copy link
Contributor

javeme commented Nov 21, 2019

Add tests for addV() with property(single/list/set)

fix #751

Change-Id: I0f818d51ca45f167df1f01ab6e6632f76f2e50fe
Change-Id: If787be79bec7a94f5142196e523127f2a9a7439b
Change-Id: Id3bdf5e3a1dce455f100626c2c514270351b3b3b
@Linary Linary force-pushed the set-property-with-cardinality branch from 004e20d to 8e615dc Compare December 13, 2019 02:56
javeme
javeme previously approved these changes Dec 17, 2019
Change-Id: I2856980df7e78ca8b65232b53c4366fe23eb4ee0
@Linary Linary force-pushed the set-property-with-cardinality branch from f11a617 to 319e629 Compare December 18, 2019 09:23
@javeme javeme merged commit e1a3336 into master Dec 18, 2019
@javeme javeme deleted the set-property-with-cardinality branch December 18, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants