Fix start.hugegraph.sh timeout when config authentication #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic22531cead13f3698791070a044d66eacb1c26ee
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
===========================================
- Coverage 71.2% 71.2% -0.01%
Complexity 4346 4346
===========================================
Files 282 282
Lines 20806 20806
Branches 2930 2930
===========================================
- Hits 14815 14814 -1
- Misses 4540 4543 +3
+ Partials 1451 1449 -2
Continue to review full report at Codecov.
|
zhoney
requested changes
Nov 27, 2019
| PASSWORD=`echo ${PASSWORD} | xargs` | ||
| fi | ||
| fi | ||
|
|
There was a problem hiding this comment.
prefer to move it into util.sh as a function
| @@ -54,6 +54,38 @@ REST_SERVER_URL=`read_property "$CONF/rest-server.properties" "restserver.url"` | |||
| check_port "$GREMLIN_SERVER_URL" | |||
| check_port "$REST_SERVER_URL" | |||
|
|
|||
|
|
|||
javeme
reviewed
Nov 27, 2019
|
If username and password is stored in db, we can't get it from shell. Prefer to add a specific user or a specific api. |
Change-Id: I45e7f6a180ed9c2f10d95157700bf48d7e17ec2e
javeme
reviewed
Dec 5, 2019
Linary
force-pushed
the
startup-with-auth
branch
from
b109890
to
c59efdb
Compare
javeme
approved these changes
Dec 5, 2019
zhoney
approved these changes
Dec 5, 2019
javeme
pushed a commit
that referenced
this pull request
Dec 6, 2019
Change-Id: Ic22531cead13f3698791070a044d66eacb1c26ee
Linary
pushed a commit
that referenced
this pull request
Dec 9, 2019
* Start service should fail quickly when occured exception (#748) Change-Id: I36803f2dcc1ae19046cfb209d67a1008df135b21 * allow rest api to query vertices & edges with multi properties by paging (#759) implemented: #658 Change-Id: Ic803bc5d11bbd77d8d2b8b7c3cc247cdd5d7781e * fix TableNotFoundException when truncate HBase store (#771) fixed: #770 Change-Id: Ibb74acc04018378a11b2d3304ea9e1437fc5879b * fix: Requested permits (0) must be positive (#773) Change-Id: I43ab6b0614e86464f2ce9824fda63df1f6dbd2f9 fix: #760 * Fix start.hugegraph.sh timeout when config authentication (#761) Change-Id: Ic22531cead13f3698791070a044d66eacb1c26ee * fix connect failed of mysql backend when using studio gremlin (#765) fixed: #758 Change-Id: Ia52ea1588b1b4ecef882732cfbb8606ceb4bea30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic22531cead13f3698791070a044d66eacb1c26ee