Support range query for rest api like P.gt(18)/P.lt(3.14) #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
============================================
+ Coverage 71.89% 71.92% +0.03%
- Complexity 4596 4619 +23
============================================
Files 295 295
Lines 21943 22014 +71
Branches 3097 3117 +20
============================================
+ Hits 15775 15833 +58
- Misses 4619 4629 +10
- Partials 1549 1552 +3 Continue to review full report at Codecov.
|
zhoney
requested changes
Dec 19, 2019
| // Convert relational operator like P.gt()/P.lt() | ||
| for (Map.Entry<String, Object> prop : props.entrySet()) { | ||
| Object value = prop.getValue(); | ||
| if (value instanceof String && ((String) value).startsWith("P.")) { |
There was a problem hiding this comment.
add a arg 'literal' to determine whether match literally, default is false
| @@ -624,4 +645,76 @@ public static QueryHolder firstPageStep(GraphTraversal<?, ?> traversal) { | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| public static P<?> parsePredicate(String predicate) { | |||
| // extract P from json string like {"properties": {"age": "P.gt(18)"}} | |||
| e.getMessage()); | ||
| }); | ||
|
|
||
| Assert.assertThrows(HugeException.class, () -> { |
There was a problem hiding this comment.
add more tests like "P.inside(5)" for "Invalid numbers size...."
Linary
previously approved these changes
Mar 4, 2020
zhoney
previously approved these changes
Apr 3, 2020
javeme
force-pushed
the
api-support-gt-lt
branch
from
ea79ad7
to
c87dd31
Compare
zhoney
previously approved these changes
Apr 4, 2020
implement: #781 Change-Id: I4a4b8a78708dff1a27d0168b27b77958ee9fcfde
Change-Id: I98ba02e0e6d551cd937c59b4d05495f8ed99198b
Change-Id: Iafbd2c6c78464dca699910faf4f2424f15300a3e
javeme
force-pushed
the
api-support-gt-lt
branch
from
c87dd31
to
ed7631f
Compare
zhoney
approved these changes
Apr 6, 2020
Linary
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement: #781
Change-Id: I4a4b8a78708dff1a27d0168b27b77958ee9fcfde