fix mismatched exception type of unique index query #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9977a4cc05e3ee30d869ea32a043eddce216fa22 fixed: #795
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
===========================================
+ Coverage 71.13% 71.74% +0.6%
- Complexity 4331 4380 +49
===========================================
Files 283 283
Lines 20957 20967 +10
Branches 2957 2959 +2
===========================================
+ Hits 14908 15043 +135
+ Misses 4568 4443 -125
Partials 1481 1481
Continue to review full report at Codecov.
|
javeme
requested changes
Dec 26, 2019
| @@ -592,7 +592,11 @@ private MatchedIndex collectMatchedIndex(SchemaLabel schemaLabel, | |||
| SchemaTransaction schema = this.graph().schemaTransaction(); | |||
| Set<IndexLabel> ils = InsertionOrderUtil.newSet(); | |||
| for (Id il : schemaLabel.indexLabels()) { | |||
| ils.add(schema.getIndexLabel(il)); | |||
| IndexLabel indexLabel = schema.getIndexLabel(il); | |||
| if (indexLabel.indexType().isUniuqe()) { | |||
| ils.add(schema.getIndexLabel(il)); | ||
| IndexLabel indexLabel = schema.getIndexLabel(il); | ||
| if (indexLabel.indexType().isUniuqe()) { | ||
| continue; |
There was a problem hiding this comment.
why not allowed to query by unique index
javeme
reviewed
Jan 6, 2020
| Assert.assertThrows(NoIndexException.class, () -> { | ||
| graph.traversal().V().hasLabel("node").has("name", "tom").next(); | ||
| }, (e) -> { | ||
| Assert.assertTrue(e.getMessage().equals( |
| Assert.assertThrows(NoIndexException.class, () -> { | ||
| graph().traversal().E().hasLabel("like").has("weight", 0.5).next(); | ||
| }, (e) -> { | ||
| Assert.assertTrue(e.getMessage().equals( |
Change-Id: Iba850b598f05a652c10659efa251fb8a7bdf20a3
Change-Id: Id1f469218e6d537b221f6d930fdd0bc9dc344c85
javeme
reviewed
Jan 7, 2020
| @@ -3588,7 +3588,6 @@ public void testRemoveVertexOfNotExists() { | |||
| graph.tx().commit(); | |||
| } | |||
|
|
|||
| @Test | |||
Change-Id: Iaddf6e070a083002b8b17e238384cdd2f7e43a1e
javeme
approved these changes
Jan 7, 2020
Linary
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #795
Change-Id: I9977a4cc05e3ee30d869ea32a043eddce216fa22