add "nodes" metadata for backends #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
+ Coverage 65.2% 71.8% +6.6%
- Complexity 4043 4372 +329
==========================================
Files 283 286 +3
Lines 20995 21073 +78
Branches 2961 2963 +2
==========================================
+ Hits 13689 15132 +1443
+ Misses 5938 4446 -1492
- Partials 1368 1495 +127
Continue to review full report at Codecov.
|
javeme
reviewed
Jan 9, 2020
| serverMetrics.getRequestCountPerSecond()); | ||
| for (RegionMetrics region : regions) { | ||
| String table = region.getNameAsString().split(",")[0]; | ||
| metrics.put(table, this.getRegionMetrics(region)); |
There was a problem hiding this comment.
don't override regions of one table
| public Map<String, Object> getMetrics() { | ||
| Map<String, Object> results = InsertionOrderUtil.newMap(); | ||
| try { | ||
| Admin admin = this.hbase.getAdmin(); |
There was a problem hiding this comment.
try(Admin admin = this.hbase.getAdmin())
|
|
||
| @Override | ||
| public Map<String, Object> getMetrics() { | ||
| return ImmutableMap.of("nodes", 1); |
|
|
||
| @Override | ||
| public Map<String, Object> getMetrics() { | ||
| return ImmutableMap.of("nodes", 1); |
| String address = server.getAddress().toString(); | ||
| List<RegionMetrics> regions = admin.getRegionMetrics(server); | ||
| regionServers.put(address, this.getRegionServerMetrics( | ||
| e.getValue(), regions)); |
There was a problem hiding this comment.
define a var for e.getValue()
javeme
reviewed
Jan 9, 2020
|
|
||
| private void registerMetaHandlers() { | ||
| this.registerMetaHandler("metrics", (session, meta, args) -> { | ||
| HbaseMetrics metrics = new HbaseMetrics(hbase()); |
There was a problem hiding this comment.
this.sessions
Cassandra protected Cluster cluster()
javeme
reviewed
Jan 9, 2020
| @@ -85,6 +85,10 @@ public HbaseSessions(HugeConfig config, String namespace, String store) { | |||
| this.namespace = namespace; | |||
| } | |||
|
|
|||
| public Connection hbase() { | |||
There was a problem hiding this comment.
set package access or protected
check this.hbase != null
| } | ||
|
|
||
| protected void registerTableManager(HugeType type, HbaseTable table) { | ||
| this.tables.put(type, table); | ||
| } | ||
|
|
||
| private Connection hbase() { |
javeme
reviewed
Jan 9, 2020
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseMetrics.java
Show resolved
Hide resolved
| return metrics; | ||
| } | ||
|
|
||
| private Map<String, Object> getRegionMetrics(RegionMetrics region) { |
There was a problem hiding this comment.
set static and rename formatMetrics
| return results; | ||
| } | ||
|
|
||
| private Map<String, Object> getRegionServerMetrics( |
There was a problem hiding this comment.
set static
and rename to formatMetrics
| serverMetrics.getRequestCountPerSecond()); | ||
| for (RegionMetrics region : regions) { | ||
| metrics.put(region.getNameAsString(), | ||
| this.getRegionMetrics(region)); |
| List<RegionMetrics> regions = admin.getRegionMetrics(server); | ||
| ServerMetrics serverMetrics = e.getValue(); | ||
| regionServers.put(address, this.getRegionServerMetrics( | ||
| serverMetrics, regions)); |
There was a problem hiding this comment.
regionServers.put(server.getAddress().toString(),
formatMetri(csserverMetrics, regions));
javeme
requested changes
Jan 26, 2020
| Map<String, Object> metrics = InsertionOrderUtil.newMap(); | ||
| metrics.put("max_heap_size", | ||
| serverMetrics.getMaxHeapSize().get(Size.Unit.MEGABYTE)); | ||
| metrics.put("used_heap_size", |
| Map<String, Object> metrics = InsertionOrderUtil.newMap(); | ||
| metrics.put("mem_store_size", | ||
| region.getMemStoreSize().get(Size.Unit.MEGABYTE)); | ||
| metrics.put("mem_store_file_size", |
| metrics.put("mem_store_size", | ||
| region.getMemStoreSize().get(Size.Unit.MEGABYTE)); | ||
| metrics.put("mem_store_file_size", | ||
| region.getStoreFileSize().get(Size.Unit.MEGABYTE)); |
implemented: #816 Change-Id: Ica7be59f1af1f290342b010c0c018cc541a1122b
Change-Id: I7538d76682d0e6620eefc3ce53c787e111ba1dcf
Change-Id: I041cf915e565b4ba90c94b73d938ff9e27abf905
javeme
approved these changes
Feb 4, 2020
Linary
approved these changes
Feb 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented: #816
Change-Id: Ica7be59f1af1f290342b010c0c018cc541a1122b