fix task-cancel error with saving failure task #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
changed the title
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
============================================
+ Coverage 69.07% 72.16% +3.09%
- Complexity 4276 4447 +171
============================================
Files 286 287 +1
Lines 21085 21167 +82
Branches 2967 2989 +22
============================================
+ Hits 14565 15276 +711
+ Misses 5086 4387 -699
- Partials 1434 1504 +70
Continue to review full report at Codecov.
|
javeme
force-pushed
the
task-bug
branch
2 times, most recently
from
94af655
to
d32a600
Compare
Change-Id: If70a2233f73c578f38842b6b015241b5ba6b86a1
Change-Id: Ia47213935de8b76691e65098e95989b152bfb4b1
Change-Id: I57bdf5eb72ccebcde186b20ee079442236d4584d
Change-Id: I0adde8d686ca10b938c2660446463fa26fd4bb89
Change-Id: I0ac694d21ea5cbdf1234490afb2afda660f1349c
Change-Id: I1a2acadd27ee7820d240c3f987b8e061c2441e55
Change-Id: I606d389f06b2f8145463586308981f741c908ac0
Change-Id: Ice0ea021096bc86046dbe6621b72c26a892ce215
Linary
requested changes
Feb 17, 2020
| @@ -50,7 +50,11 @@ public String type() { | |||
|
|
|||
| @Override | |||
| public Object execute() { | |||
| this.rebuildIndex(this.schemaElement()); | |||
| SchemaElement schema = this.schemaElement(); | |||
There was a problem hiding this comment.
When will the schema be null
There was a problem hiding this comment.
Maybe the schema is removed when task running, I'm not quite sure of the exact scene.
| public Integer call() throws Exception { | ||
| Thread.sleep(SLEEP_TIME); | ||
| return 125; | ||
| } |
Change-Id: Ib9a26b1851b8477da8c20df77a19a4a2c9589a34
Linary
approved these changes
Feb 21, 2020
Linary
previously approved these changes
Feb 21, 2020
| HugeGraph graph = graph(); | ||
| TaskScheduler scheduler = graph.taskScheduler(); | ||
|
|
||
| TaskCallable<Integer> callable = new TaskCallable<Integer>() { |
| HugeGraph graph = graph(); | ||
| TaskScheduler scheduler = graph.taskScheduler(); | ||
|
|
||
| TaskCallable<Integer> callable = new TaskCallable<Integer>() { |
zhoney
requested changes
Feb 21, 2020
|
|
||
| @After | ||
| @Override | ||
| public void setup() { |
Change-Id: Idb4fe8d349c09d0384705641b27efddef10f44c2
zhoney
requested changes
Feb 23, 2020
| Assert.assertTrue(task.result(), task.result() == null || | ||
| task.result().endsWith("InterruptedException")); | ||
|
|
||
| // cancel success task |
Change-Id: Ib61c8cdae2e73d346dd611791d47faa30eac6e5a
zhoney
approved these changes
Feb 23, 2020
Linary
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is caused by failure task status has not been saved to backend store(
the root cause is result size exceeded 64k, and failed to save), so its status is
still RUNNING even the task is finished, if call cancel() then the task will be loaded
from backend store and its scheduler is null.
fix apache/incubator-hugegraph-tools#50
Change-Id: If70a2233f73c578f38842b6b015241b5ba6b86a1