add option vertex.check_adjacent_vertex_exist #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=========================================
Coverage 72.25% 72.26%
- Complexity 4487 4498 +11
=========================================
Files 287 287
Lines 21412 21430 +18
Branches 3017 3022 +5
=========================================
+ Hits 15472 15487 +15
- Misses 4428 4431 +3
Partials 1512 1512
Continue to review full report at Codecov.
|
javeme
commented
Feb 7, 2020
| query.mustSortByInput(false); | ||
| Iterator<HugeVertex> it = this.queryVerticesFromBackend(query); | ||
| QueryResults.fillMap(it, vertices); | ||
| } | ||
|
|
||
| return new MapperIterator<>(ids.iterator(), id -> { | ||
| return vertices.get(id); | ||
| HugeVertex vertex = vertices.get(id); |
There was a problem hiding this comment.
TODO: deal vertex with unmatch label
check_adjacent_vertex_exist=true: throw exception: vertex does not exist check_adjacent_vertex_exist=false: return vertex with "~undefined" label if not exist adjacent vertex, fix: #835 Change-Id: I30ce32ae358d0483888895a0017b77d55f346491
fix: #835 Change-Id: Iac7ea3c51092253f20a35a579460d8c7124c5f94
javeme
force-pushed
the
check_adjacent_vertex_exist
branch
from
140ba77
to
6fce93b
Compare
Linary
approved these changes
Mar 19, 2020
zhoney
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when check_adjacent_vertex_exist=true:
throw exception: "vertex does not exist" if not exist adjacent vertex
when check_adjacent_vertex_exist=false:
return vertex with "~undefined" label if not exist adjacent vertex
fix: #835
Change-Id: I30ce32ae358d0483888895a0017b77d55f346491