Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not allowed empty primary values #847

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Not allowed empty primary values #847

merged 1 commit into from
Feb 4, 2020

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Feb 3, 2020

Change-Id: I6b7502892383d08348734502d0e59f5d94128fc7

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #847 into master will decrease coverage by 15.48%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #847       +/-   ##
=============================================
- Coverage     71.16%   55.68%   -15.49%     
+ Complexity     4358     3368      -990     
=============================================
  Files           283      283               
  Lines         20967    20968        +1     
  Branches       2959     2960        +1     
=============================================
- Hits          14921    11675     -3246     
- Misses         4566     7975     +3409     
+ Partials       1480     1318      -162
Impacted Files Coverage Δ Complexity Δ
...java/com/baidu/hugegraph/structure/HugeVertex.java 76.62% <100%> (-2.08%) 66 <0> (-9)
.../backend/store/scylladb/ScyllaDBStoreProvider.java 0% <0%> (-100%) 0% <0%> (-7%)
...graph/backend/store/scylladb/ScyllaDBFeatures.java 0% <0%> (-100%) 0% <0%> (-3%)
...ackend/store/cassandra/CassandraStoreProvider.java 0% <0%> (-100%) 0% <0%> (-6%)
...va/com/baidu/hugegraph/io/HugeGraphIoRegistry.java 0% <0%> (-100%) 0% <0%> (-4%)
...aidu/hugegraph/exception/HugeGremlinException.java 0% <0%> (-100%) 0% <0%> (-3%)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 0% <0%> (-96.04%) 0% <0%> (-10%)
...ava/com/baidu/hugegraph/analyzer/WordAnalyzer.java 0% <0%> (-92.31%) 0% <0%> (-4%)
...h/backend/store/cassandra/CassandraSerializer.java 0% <0%> (-90.48%) 0% <0%> (-27%)
...aph/backend/serializer/BinaryInlineSerializer.java 0% <0%> (-90.33%) 0% <0%> (-10%)
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8041b93...5047f2a. Read the comment docs.

@@ -115,6 +115,8 @@ public String name() {
"Primary values must not be empty " +
"(has properties %s)", hasProperties());
this.name = SplicingIdGenerator.concatValues(propValues);
E.checkArgument(!this.name.isEmpty(),
"The primary values can't be empty");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of primary key can't be empty

@Linary Linary force-pushed the check-pkvalue-notempty branch 2 times, most recently from 88454c5 to bb22551 Compare February 4, 2020 02:31
Change-Id: I6b7502892383d08348734502d0e59f5d94128fc7
@zhoney zhoney merged commit 083859b into master Feb 4, 2020
@zhoney zhoney deleted the check-pkvalue-notempty branch February 4, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants