add graph name check in gremlin and rest config #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
============================================
+ Coverage 70.73% 71.81% +1.08%
- Complexity 4327 4388 +61
============================================
Files 286 286
Lines 21073 21090 +17
Branches 2963 2967 +4
============================================
+ Hits 14906 15146 +240
+ Misses 4686 4453 -233
- Partials 1481 1491 +10 Continue to review full report at Codecov.
|
Linary
requested changes
Feb 18, 2020
fixed: #850 Change-Id: I5c4c82c784aebeb0bfe910107d7d4e19abc62d7c
zhoney
changed the title
javeme
requested changes
Feb 18, 2020
| @@ -57,6 +60,7 @@ | |||
| exceptions.put("InvalidQueryException", "unconfigured table"); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
| @@ -83,7 +87,15 @@ public static void main(String[] args) | |||
| "Must contain at least one graph"); | |||
|
|
|||
| for (ConfigurationNode graphName : graphNames) { | |||
| String name = ((Map.Entry<String, Object>) | |||
| graphName.getReference()).getKey(); | |||
There was a problem hiding this comment.
can we call graphName.getName()
There was a problem hiding this comment.
graphName.getName() returns 'graph' due to it's sub node of 'graphs'
| " valid graph name is up to 48 alpha-numeric " + | ||
| "characters and underscores and only letters are " + | ||
| "supported as first letter. " + | ||
| "Note: letter is case insensitive", name); |
There was a problem hiding this comment.
seems better to add a method checkGraphName()
javeme
approved these changes
Feb 19, 2020
Linary
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #850
Change-Id: I5c4c82c784aebeb0bfe910107d7d4e19abc62d7c