fix leak of absolute path in gremlin #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I2e066014a3993862f3bea830dd4a683d2c7b6f63
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
============================================
- Coverage 72.12% 72.11% -0.01%
Complexity 4450 4450
============================================
Files 287 287
Lines 21201 21208 +7
Branches 2992 2992
============================================
+ Hits 15291 15294 +3
- Misses 4404 4408 +4
Partials 1506 1506
Continue to review full report at Codecov.
|
Change-Id: I31bfc7faa89c226cb26fd4f2154d226904aec0ab
javeme
requested changes
Feb 27, 2020
| SerializerProvider provider) | ||
| throws IOException { | ||
| jsonGenerator.writeStartObject(); | ||
| jsonGenerator.writeStringField("fileName", file.getName()); |
There was a problem hiding this comment.
fileName => file_name or file
javeme
approved these changes
Feb 28, 2020
Linary
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I2e066014a3993862f3bea830dd4a683d2c7b6f63