Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode label id in string index #894

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Mar 15, 2020

Change-Id: Ia7c1be49c740a654dd687a79686a1044be10bd1f

Change-Id: Ia7c1be49c740a654dd687a79686a1044be10bd1f
Change-Id: I258bf91be896df48d19aac8194d632b1b22c30d0
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #894 into master will increase coverage by 0.02%.
The diff coverage is 89.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #894      +/-   ##
============================================
+ Coverage     72.23%   72.25%   +0.02%     
- Complexity     4487     4497      +10     
============================================
  Files           287      287              
  Lines         21411    21438      +27     
  Branches       3017     3025       +8     
============================================
+ Hits          15467    15491      +24     
- Misses         4432     4433       +1     
- Partials       1512     1514       +2     
Impacted Files Coverage Δ Complexity Δ
...u/hugegraph/backend/serializer/TextSerializer.java 86.57% <ø> (ø) 88.00 <0.00> (ø)
.../backend/store/memory/InMemoryDBStoreProvider.java 100.00% <ø> (ø) 11.00 <0.00> (ø)
...java/com/baidu/hugegraph/schema/SchemaElement.java 79.31% <ø> (-0.36%) 26.00 <0.00> (-1.00)
...egraph/backend/store/hbase/HbaseStoreProvider.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...egraph/backend/store/mysql/MysqlStoreProvider.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...kend/store/postgresql/PostgresqlStoreProvider.java 92.10% <ø> (ø) 5.00 <0.00> (ø)
...ph/backend/store/rocksdb/RocksDBStoreProvider.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.75% <75.00%> (-0.10%) 185.00 <0.00> (ø)
...hugegraph/backend/serializer/BinarySerializer.java 83.30% <81.25%> (-0.09%) 104.00 <4.00> (ø)
...va/com/baidu/hugegraph/backend/id/IdGenerator.java 82.20% <100.00%> (ø) 19.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9166c26...8f22b35. Read the comment docs.

@@ -325,7 +325,7 @@ else if (type == HugeType.SYS_PROPERTY.code()) {
int idLen = 1 + elemId.length();
buffer = BytesBuffer.allocate(idLen);
// Write element-id
buffer.writeId(elemId, true);
buffer.writeId(elemId);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change-Id: Ifd1aa767ec727f717ede9f29ea28cb9fc6e79c41
Change-Id: Iba8e3f2056452d2031a788c15c5b26ca3708f376
Change-Id: I963f7a10449faf90b67e2536bb0a286abe2225fa
@Linary Linary merged commit 52e8f42 into master Mar 30, 2020
@Linary Linary deleted the string-index-encode-label-id branch March 30, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants