Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for ap algo #921

Merged
merged 8 commits into from
Apr 5, 2020
Merged

prepare for ap algo #921

merged 8 commits into from
Apr 5, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Mar 31, 2020

Change-Id: Ic0ea69b80a49d0e5da04e862d102f78e89bcf86e

Change-Id: Ic0ea69b80a49d0e5da04e862d102f78e89bcf86e
Change-Id: Ie3d7a04d649ab476b561447849366d7ee6af12ac
Change-Id: I9c45cd91f07abbbd421fcf3e48531f03dc8d35bb
Change-Id: Icfe2e6be4e942da49033f2076c923563ea0dd047
Change-Id: Ia6dd6cd9b5ccf5eb2d240b1f92e09cdd302a7126
@javeme
Copy link
Contributor Author

javeme commented Apr 1, 2020

image

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #921 into master will decrease coverage by 0.20%.
The diff coverage is 73.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #921      +/-   ##
============================================
- Coverage     72.30%   72.10%   -0.21%     
- Complexity     4511     4595      +84     
============================================
  Files           287      290       +3     
  Lines         21464    21876     +412     
  Branches       3040     3095      +55     
============================================
+ Hits          15520    15774     +254     
- Misses         4428     4553     +125     
- Partials       1516     1549      +33     
Impacted Files Coverage Δ Complexity Δ
...baidu/hugegraph/backend/store/BackendMutation.java 82.56% <0.00%> (-3.15%) 32.00 <0.00> (ø)
...ore/src/main/java/com/baidu/hugegraph/job/Job.java 63.88% <0.00%> (-7.99%) 8.00 <0.00> (ø)
...java/com/baidu/hugegraph/schema/SchemaElement.java 77.96% <0.00%> (-1.35%) 26.00 <1.00> (ø)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 70.38% <0.00%> (-0.94%) 65.00 <0.00> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.45% <14.28%> (-0.57%) 186.00 <0.00> (ø)
...c/main/java/com/baidu/hugegraph/util/JsonUtil.java 62.71% <27.27%> (-8.13%) 8.00 <0.00> (ø)
...c/main/java/com/baidu/hugegraph/HugeException.java 86.66% <50.00%> (-5.65%) 7.00 <1.00> (+1.00) ⬇️
...ain/java/com/baidu/hugegraph/schema/EdgeLabel.java 80.64% <50.00%> (+2.86%) 16.00 <4.00> (+2.00)
...ava/com/baidu/hugegraph/structure/HugeElement.java 68.66% <50.00%> (+1.09%) 52.00 <1.00> (+2.00)
...idu/hugegraph/backend/tx/IndexableTransaction.java 85.18% <66.66%> (ø) 15.00 <0.00> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f1e77...c9d569b. Read the comment docs.

Linary
Linary previously approved these changes Apr 3, 2020
@@ -510,6 +551,12 @@ public void removeVertex(HugeVertex vertex) {
}

public Iterator<Vertex> queryAdjacentVertices(Iterator<Edge> edges) {
if(this.lazyLoadAdjacentVertex){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty after "if"

Change-Id: Ic26c00dbb4636a0ec8bfc133c1bee8229b304bcb
zhoney
zhoney previously approved these changes Apr 4, 2020
@javeme
Copy link
Contributor Author

javeme commented Apr 4, 2020

pg ci error:

[ERROR] Tests run: 588, Failures: 0, Errors: 1, Skipped: 28, Time elapsed: 72.951 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
[ERROR] testTask(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 1.2 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '88888'
	at com.baidu.hugegraph.core.TaskCoreTest.testTask(TaskCoreTest.java:105)

used by parse entry

Change-Id: I23e3214f4347de7348c7d275cf5caefcbe68077c
Change-Id: Ie4810f60e705c55c0be66afe93d68e890d3b7d87
@javeme javeme merged commit fc8f735 into master Apr 5, 2020
@javeme javeme deleted the olap-algo branch April 5, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants