Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check cache value size #933

Merged
merged 1 commit into from
Apr 8, 2020
Merged

check cache value size #933

merged 1 commit into from
Apr 8, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 7, 2020

Change-Id: I56d83d37fab7bcf7f19e1fb17fcf566ad50d8ef4

@javeme
Copy link
Contributor Author

javeme commented Apr 7, 2020

java.lang.IllegalArgumentException: The max length of bytes is 65535, but got 90334
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:146) ~[guava-19.0.jar:?]
	at com.baidu.hugegraph.util.E.checkArgument(E.java:56) ~[hugegraph-common-1.7.5.jar:1.7.5.0]
	at com.baidu.hugegraph.backend.serializer.BytesBuffer.writeBytes(BytesBuffer.java:281) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache$Value.serializeElement(OffheapCache.java:293) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache$Value.serialize(OffheapCache.java:233) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache$Value.asBuffer(OffheapCache.java:215) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache$Value.serializedSize(OffheapCache.java:204) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache$ValueSerializer.serializedSize(OffheapCache.java:180) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache$ValueSerializer.serializedSize(OffheapCache.java:1) ~[classes/:?]
	at org.caffinitas.ohc.linked.OHCacheLinkedImpl.valueSize(OHCacheLinkedImpl.java:309) ~[ohc-core-0.7.0.jar:?]
	at org.caffinitas.ohc.linked.OHCacheLinkedImpl.putInternal(OHCacheLinkedImpl.java:249) ~[ohc-core-0.7.0.jar:?]
	at org.caffinitas.ohc.linked.OHCacheLinkedImpl.put(OHCacheLinkedImpl.java:220) ~[ohc-core-0.7.0.jar:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache.write(OffheapCache.java:120) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.OffheapCache.write(OffheapCache.java:1) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.LevelCache.write(LevelCache.java:92) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.LevelCache.write(LevelCache.java:1) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.AbstractCache.update(AbstractCache.java:125) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.CachedGraphTransaction.queryVerticesByIds(CachedGraphTransaction.java:194) ~[classes/:?]
	at com.baidu.hugegraph.backend.cache.CachedGraphTransaction.queryVerticesFromBackend(CachedGraphTransaction.java:162) ~[classes/:?]
	at com.baidu.hugegraph.backend.tx.GraphTransaction.queryVertices(GraphTransaction.java:626) ~[classes/:?]
	at com.baidu.hugegraph.backend.tx.GraphTransaction.queryAdjacentVertices(GraphTransaction.java:588) ~[classes/:?]

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #933 into master will decrease coverage by 0.01%.
The diff coverage is 68.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #933      +/-   ##
============================================
- Coverage     72.04%   72.02%   -0.02%     
  Complexity     4674     4674              
============================================
  Files           298      298              
  Lines         22293    22295       +2     
  Branches       3153     3154       +1     
============================================
- Hits          16060    16059       -1     
- Misses         4671     4675       +4     
+ Partials       1562     1561       -1     
Impacted Files Coverage Δ Complexity Δ
...om/baidu/hugegraph/backend/cache/OffheapCache.java 75.30% <50.00%> (-1.25%) 16.00 <3.00> (ø)
...m/baidu/hugegraph/backend/cache/AbstractCache.java 69.38% <83.33%> (-0.91%) 28.00 <0.00> (ø)
.../com/baidu/hugegraph/backend/cache/LevelCache.java 92.10% <100.00%> (+0.21%) 19.00 <2.00> (ø)
...va/com/baidu/hugegraph/backend/cache/RamCache.java 71.83% <100.00%> (ø) 27.00 <0.00> (ø)
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 83.14% <0.00%> (-0.38%) 62.00% <0.00%> (ø%)
...a/com/baidu/hugegraph/backend/query/Condition.java 79.66% <0.00%> (+0.41%) 31.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b1853...17e3c63. Read the comment docs.

Change-Id: I56d83d37fab7bcf7f19e1fb17fcf566ad50d8ef4
@javeme javeme merged commit 631d287 into master Apr 8, 2020
@javeme javeme deleted the offheap-check-value-size branch April 8, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants