fix ring assert error and handle two A->B not ring #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iaff8c4f16e34eb12f0fed2b33487735f783ae0ec
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
============================================
+ Coverage 71.73% 71.95% +0.22%
- Complexity 4648 4674 +26
============================================
Files 298 298
Lines 22317 22317
Branches 3157 3157
============================================
+ Hits 16009 16059 +50
+ Misses 4741 4697 -44
+ Partials 1567 1561 -6 Continue to review full report at Codecov.
|
javeme
approved these changes
Apr 10, 2020
javeme
approved these changes
Apr 10, 2020
javeme
requested changes
Apr 10, 2020
| } else { | ||
| hasInEdge = true; | ||
| } | ||
| if (hasOutEdge && hasInEdge) { |
There was a problem hiding this comment.
oh seems the graph itself exist both direction edges between tow vertices
javeme
approved these changes
Apr 10, 2020
| } else { | ||
| hasInEdge = true; | ||
| } | ||
| if (hasOutEdge && hasInEdge) { |
There was a problem hiding this comment.
oh seems the graph itself exist both direction edges between tow vertices
Linary
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Iaff8c4f16e34eb12f0fed2b33487735f783ae0ec