Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize list property read #943

Merged
merged 4 commits into from
Apr 12, 2020
Merged

optimize list property read #943

merged 4 commits into from
Apr 12, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 11, 2020

Change-Id: I621e5cb441f48c961ffc5ea78a83d5428238c4c2

Change-Id: I621e5cb441f48c961ffc5ea78a83d5428238c4c2
Change-Id: I0f05c8f6484c392a5fb278ec2c92b9d2a4d906b5
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #943 into master will increase coverage by 0.01%.
The diff coverage is 84.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #943      +/-   ##
============================================
+ Coverage     71.93%   71.95%   +0.01%     
- Complexity     4676     4679       +3     
============================================
  Files           298      298              
  Lines         22330    22339       +9     
  Branches       3162     3165       +3     
============================================
+ Hits          16063    16073      +10     
  Misses         4700     4700              
+ Partials       1567     1566       -1     
Impacted Files Coverage Δ Complexity Δ
...m/baidu/hugegraph/backend/cache/AbstractCache.java 69.38% <33.33%> (ø) 28.00 <9.00> (ø)
...n/java/com/baidu/hugegraph/schema/PropertyKey.java 83.00% <75.00%> (-0.84%) 45.00 <0.00> (ø)
...a/com/baidu/hugegraph/backend/query/Condition.java 79.67% <100.00%> (+0.83%) 31.00 <0.00> (ø)
.../java/com/baidu/hugegraph/backend/query/Query.java 84.72% <100.00%> (ø) 93.00 <0.00> (ø)
...hugegraph/backend/serializer/BinarySerializer.java 83.19% <100.00%> (-0.06%) 106.00 <0.00> (-1.00)
...n/java/com/baidu/hugegraph/structure/HugeEdge.java 74.13% <100.00%> (+0.14%) 75.00 <0.00> (+1.00)
...ava/com/baidu/hugegraph/structure/HugeElement.java 70.37% <100.00%> (+0.75%) 57.00 <0.00> (+2.00)
...n/java/com/baidu/hugegraph/task/TaskScheduler.java 83.14% <0.00%> (-0.38%) 62.00% <0.00%> (ø%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.58% <0.00%> (+0.12%) 186.00% <0.00%> (ø%)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 71.53% <0.00%> (+0.36%) 66.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad2ab1...8f3efec. Read the comment docs.

Change-Id: Ic066730ccf5f35f71a56156389c55085cd34f2cb
Change-Id: Ie1edacdfaf5028fea184fde6f787fa05a13c9ac3
value.getClass().getSimpleName());
if (validValue == null) {
E.checkArgument(validValue != null,
"Invalid property value '%s' for key '%s', " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false

@Linary Linary merged commit 0eb7bee into master Apr 12, 2020
@Linary Linary deleted the optimize-prop-read branch April 12, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants