Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permission overflow from return results #969

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 23, 2020

also:
* hide private methods and fields for reflection that require permissions
* delete stale index of task directly

implement: #209
Change-Id: Iccfbd47c213e1e13122190d1242778031e8a957c

rebase and closed #956

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #969 into master will decrease coverage by 0.44%.
The diff coverage is 61.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #969      +/-   ##
============================================
- Coverage     71.42%   70.98%   -0.45%     
- Complexity     4887     5000     +113     
============================================
  Files           309      311       +2     
  Lines         23485    23942     +457     
  Branches       3305     3349      +44     
============================================
+ Hits          16775    16996     +221     
- Misses         5067     5295     +228     
- Partials       1643     1651       +8     
Impacted Files Coverage Δ Complexity Δ
...idu/hugegraph/api/filter/AuthenticationFilter.java 28.98% <0.00%> (-3.28%) 0.00 <0.00> (ø)
...n/java/com/baidu/hugegraph/api/graph/BatchAPI.java 27.41% <0.00%> (+0.43%) 0.00 <0.00> (ø)
...n/java/com/baidu/hugegraph/api/job/GremlinAPI.java 17.39% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/baidu/hugegraph/api/profile/GraphsAPI.java 13.51% <0.00%> (-0.38%) 0.00 <0.00> (ø)
...a/com/baidu/hugegraph/api/traversers/EdgesAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...om/baidu/hugegraph/api/traversers/VerticesAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...om/baidu/hugegraph/api/variables/VariablesAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../com/baidu/hugegraph/auth/ConfigAuthenticator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...om/baidu/hugegraph/auth/StandardAuthenticator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17417df...2c8eb8c. Read the comment docs.

also:
 * hide private methods and fields for reflection that require permissions
 * delete stale index of task directly

Change-Id: Iccfbd47c213e1e13122190d1242778031e8a957c
separate commits to avoid no git diff

Change-Id: Ifc0319e77013743e1a30560354bc77d664f8c5d8
@javeme javeme force-pushed the user-passwd-store-overflow-permission-0.11-rebase branch from a03ed60 to 2c8eb8c Compare April 23, 2020 12:09
@javeme javeme merged commit 26c4498 into master Apr 24, 2020
@javeme javeme deleted the user-passwd-store-overflow-permission-0.11-rebase branch April 24, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants