support results count for kneighbor/kout/rings #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
============================================
- Coverage 69.54% 69.52% -0.02%
- Complexity 5249 5274 +25
============================================
Files 324 325 +1
Lines 25730 25805 +75
Branches 3619 3631 +12
============================================
+ Hits 17893 17940 +47
- Misses 6110 6142 +32
+ Partials 1727 1723 -4
Continue to review full report at Codecov.
|
implement: #994 Change-Id: Ieb7702a1bb8304391585704469cc7c7f6b07f565
Change-Id: Id9a2268d8f768d4b66e4b6499b7bb6d78212d1bb
javeme
requested changes
May 25, 2020
| if (countOnly) { | ||
| return manager.serializer(g).writeMap(ImmutableMap.of( | ||
| "count", paths.size())); | ||
| } |
| public static class Step { | ||
|
|
||
| private Directions direction; | ||
| private Map<Id, String> labels; |
There was a problem hiding this comment.
add properties for filtering sortkey:
private Map<String, Object> properties;
| return this.edgesOfVertex(target, currentStep); | ||
| }); | ||
| } else { | ||
| // The last step, just query count |
| return new FilterIterator<>(flatten, e -> { | ||
| if (this.containsTraversed) { | ||
| // Count intermediate vertices | ||
| this.count[0]++; |
There was a problem hiding this comment.
change count[0] to MutateLong
javeme
reviewed
May 26, 2020
| // Wrap steps to Iterator except last step | ||
| for (int i = 1; i < stepNum - 1; i++) { | ||
| Step currentStep = steps.get(i); | ||
| if (i != stepNum - 1) { |
| return graph().queryNumber(query).longValue(); | ||
| } | ||
|
|
||
| private void filterBySortKeys(Query query, Map<Id, String> labels, |
javeme
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement: #994
Change-Id: Ieb7702a1bb8304391585704469cc7c7f6b07f565