[Baseline] Apply baseline to iceberg-orc #158 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdsr
changed the title
rdblue
reviewed
Jun 11, 2019
| return this; | ||
| } | ||
|
|
||
| public ReadBuilder schema(org.apache.iceberg.Schema schema) { | ||
| this.schema = schema; | ||
| public ReadBuilder schema(org.apache.iceberg.Schema projectedSchema) { |
There was a problem hiding this comment.
Nit: should probably be "projectSchema" not "projected". It doesn't make sense to use past tense; this is configuring a read that hasn't happened yet.
rdblue
reviewed
Jun 11, 2019
| Function<TypeDescription, OrcValueWriter<?>> createWriterFunc) { | ||
| private static <D> OrcValueWriter<D> newOrcValueWriter( | ||
| TypeDescription schema, | ||
| Function<TypeDescription, OrcValueWriter<?>> createWriterFunc) { |
There was a problem hiding this comment.
I don't think this should have a newline. These should fit on one line, right?
|
I'd merge this since there are only nits, but it conflicts with the baseline patch I just merged. Could you rebase and update? |
deniskuzZ
added a commit
to deniskuzZ/iceberg
that referenced
this pull request
May 8, 2024
(cherry picked from commit a41412bab8abb35be7f58a83ea2c6da4e5fc1880) Change-Id: I5eea21f01f12a8b5c27e2595717427ad9284064d fix: added github workflow yml (apache#209) (cherry picked from commit fe20aaeb356c214d4590c691846e879c5ec7b6ea) added github workflow yml (apache#206) (cherry picked from commit 1fea75cf9e56b25942662092ffdc3cc2b425cc3d) Change-Id: If1b1e404b10c9507e417166453a7eaa2aef98cf9 (cherry picked from commit 153c7d1a15597b5c0577641a517f9aebad17c912) (cherry picked from commit 6a8a15520a0f045702a9f50aa93e52f34d1d3bb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply baseline to iceberg-orc #158