Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ SDK cant not return the whether the partition has been registered correctly #1568

Closed
TszKitLo40 opened this issue Sep 17, 2021 · 1 comment · Fixed by #1576
Closed

C++ SDK cant not return the whether the partition has been registered correctly #1568

TszKitLo40 opened this issue Sep 17, 2021 · 1 comment · Fixed by #1576
Assignees
Labels
Milestone

Comments

@TszKitLo40
Copy link
Contributor

Expected behavior

Tell us what should happen
C++ SDK cant not return the whether the partition has been registered correctly

Actual behavior

Tell us what happens instead

https://github.com/apache/incubator-inlong/blob/4b2223269da92aacd0cec8d40da4d624dc42ca3e/inlong-tubemq/tubemq-client-twins/tubemq-client-cpp/src/rmt_data_cache.cc#L458

In the function IsPartitionFirstReg, if part_reg_booked_ can't find the partition, it will add the partition to the map and return true. And if the function is called second time, it will also return true because the status has been set to true.

Steps to reproduce

How can we reproduce the issue

System configuration

InLong version: 0.11.0

@gosonzhang gosonzhang self-assigned this Sep 18, 2021
@gosonzhang gosonzhang added this to the 0.11.0 milestone Sep 18, 2021
@gosonzhang
Copy link
Contributor

@TszKitLo40, yes, you are right, thanks!

I'll fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants