Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1568][TubeMQ] C++ SDK cant not return the whether the partition has been registered correctly #1576

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

gosonzhang
Copy link
Contributor

Fixes #1568

@gosonzhang gosonzhang self-assigned this Sep 19, 2021
@gosonzhang gosonzhang added this to the 0.11.0 milestone Sep 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1576 (2edeba8) into master (5807044) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1576      +/-   ##
============================================
- Coverage     12.19%   12.19%   -0.01%     
- Complexity     1046     1048       +2     
============================================
  Files           392      392              
  Lines         32755    32755              
  Branches       5159     5159              
============================================
- Hits           3996     3994       -2     
  Misses        27995    27995              
- Partials        764      766       +2     
Impacted Files Coverage Δ
.../java/org/apache/flume/sink/tubemq/TubemqSink.java 51.42% <0.00%> (-4.00%) ⬇️
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.31% <0.00%> (+1.17%) ⬆️
.../client/producer/qltystats/BrokerStatsItemSet.java 72.09% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5807044...2edeba8. Read the comment docs.

@dockerzhang dockerzhang changed the title [INLONG-1568]C++ SDK cant not return the whether the partition has been registered correctly [INLONG-1568][TubeMQ] C++ SDK cant not return the whether the partition has been registered correctly Sep 20, 2021
Copy link
Contributor

@dockerzhang dockerzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 822669a into apache:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ SDK cant not return the whether the partition has been registered correctly
3 participants