Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review DRLParser.g4 and DRL6Expressions.g4 to replace IDENTIFIER with drlIdentifier #5784

Closed
tkobayas opened this issue Mar 14, 2024 · 2 comments
Closed

Review DRLParser.g4 and DRL6Expressions.g4 to replace IDENTIFIER with drlIdentifier #5784

tkobayas opened this issue Mar 14, 2024 · 2 comments
Assignees
@tkobayas

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Mar 14, 2024 •
edited

Parent issue

Failing tests

Not identified at the moment.

Issue

#5776 covers only primary rule. This issue is to

  • Review whole DRLParser.g4 and DRL6Expressions.g4 to replace IDENTIFIER with drlIdentifier if required.
  • Add unit tests for the cases. They may be minor edge cases.
@tkobayas tkobayas self-assigned this Mar 14, 2024
@tkobayas tkobayas mentioned this issue Mar 14, 2024
Merged
@yurloc yurloc mentioned this issue Apr 24, 2024
Merged
@tkobayas
Copy link
Contributor Author

/take

@tkobayas tkobayas changed the title Review DRL6Expressions.g4 to replace IDENTIFIER with drlIdentifier Review DRLParser.g4 and DRL6Expressions.g4 to replace IDENTIFIER with drlIdentifier Apr 26, 2024
This was referenced Apr 26, 2024
Open
Merged
@tkobayas
Copy link
Contributor Author

tkobayas commented May 1, 2024

Done by #5875

@tkobayas tkobayas closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkobayas tkobayas

Labels
None yet
Projects
🦉 KIE Podling Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkobayas