Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drools-3838] Improve error reporting in scenario result #2335

Merged
merged 3 commits into from
May 13, 2019
Merged

[Drools-3838] Improve error reporting in scenario result #2335

merged 3 commits into from
May 13, 2019

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented May 8, 2019 •
edited
Loading

This PR contains the server side and api changes required for https://issues.jboss.org/browse/DROOLS-3838.
Related PR on drools-wb which cointans frontend change is here kiegroup/drools-wb#1125

@jomarko @danielezonca @gitgabrio can you please review and test it?

PRs list:
kiegroup/drools-wb#1125

Thanks

@yesamer yesamer mentioned this pull request May 8, 2019
Merged
@yesamer yesamer changed the title [Drools 3838] Improve error reporting in scenario result [Drools-3838] Improve error reporting in scenario result May 8, 2019
jomarko
jomarko reviewed May 9, 2019
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesamer this part of ensemble looks good to me, however I think we should use use just one assertion framework in the test to not cause confusion when reading tests, I prepared changes you can merge to your fork and they will appear in this PR.

yesamer#1

@yesamer
Copy link
Contributor Author

yesamer commented May 9, 2019

@jomarko Merged!

jomarko
jomarko approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesamer thank you!

danielezonca
danielezonca approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

@manstis manstis merged commit 8792ae7 into apache:master May 13, 2019
@yesamer yesamer deleted the DROOLS-3838 branch June 12, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielezonca danielezonca danielezonca approved these changes

@jomarko jomarko jomarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yesamer @danielezonca @jomarko @manstis