[DROOLS-6917] Remove use of hamcrest in drools tests #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
approved these changes
Apr 25, 2022
tarilabs
approved these changes
Apr 26, 2022
mariofusco
approved these changes
Apr 26, 2022
pibizza
added a commit
to pibizza/drools
that referenced
this pull request
May 5, 2022
mariofusco
pushed a commit
that referenced
this pull request
May 10, 2022
pibizza
added a commit
to pibizza/drools
that referenced
this pull request
Mar 9, 2023
pibizza
added a commit
to pibizza/drools
that referenced
this pull request
Mar 9, 2023
pibizza
added a commit
to pibizza/drools
that referenced
this pull request
Mar 9, 2023
mariofusco
pushed a commit
that referenced
this pull request
Mar 16, 2023
… 7.67.x (#5079) * [DROOLS-6917] Remove use of hamcrest in drools tests (#4336) * [DROOLS-6930] Migrate assertNotNull to assertj assertions * [7.x][DROOLS-6931] Migrate assertions in kie-pmml-trusty tests to assertj (#4399) * Migrated assertions from junit to assertj * Making tests better use of assertj * Proper conversion for equalsNode * [7.x][DROOLS-6932] Migrate assertions in kie-dmn tests to assertj (#4435) * [DROOLS-6932] Migrate assertions in kie-dmn tests to assertj * [DROOLS-6932] Fixed code smell in test * [DROOLS-6932] Fixed compilation issue * [7.x][DROOLS-6933] Migrate drools-core tests to assertj (#4489) * [DROOLS-6933] Migrate drools-core tests to assertj (#4436) * [DROOLS-6933] Migrate more drools-core tests to assertj * [7.x][DROOLS-6935] Migrate drools-verifier tests to assertj (#4502) * [DROOLS-6935] Migrate drools-verifier tests to assertj * [DROOLS-6935] Missing cleaning in the code * [DROOLS-6934] Migrate drools-model tests to assertj (#4532) * [7.x][DROOLS-7046] Migrate drools-test-coverage tests to assertj (#4538) * [DROOLS-7046] Migrate drools-test-coverage tests to assertj * [DROOLS-7046] Cleaning up remaing tests in drools-test-coverage * [DROOLS-7053] Migrate remaining tests to assertj (#4540)
mariofusco
pushed a commit
that referenced
this pull request
Mar 16, 2023
….x (#5078) * [DROOLS-6917] Remove use of hamcrest in drools tests (#4336) * [DROOLS-6930] Migrate assertNotNull to assertj assertions * [7.x][DROOLS-6931] Migrate assertions in kie-pmml-trusty tests to assertj (#4399) * Migrated assertions from junit to assertj * Making tests better use of assertj * Proper conversion for equalsNode * [7.x][DROOLS-6932] Migrate assertions in kie-dmn tests to assertj (#4435) * [DROOLS-6932] Migrate assertions in kie-dmn tests to assertj * [DROOLS-6932] Fixed code smell in test * [DROOLS-6932] Fixed compilation issue * [7.x][DROOLS-6933] Migrate drools-core tests to assertj (#4489) * [DROOLS-6933] Migrate drools-core tests to assertj (#4436) * [DROOLS-6933] Migrate more drools-core tests to assertj * [7.x][DROOLS-6935] Migrate drools-verifier tests to assertj (#4502) * [DROOLS-6935] Migrate drools-verifier tests to assertj * [DROOLS-6935] Missing cleaning in the code * [DROOLS-6934] Migrate drools-model tests to assertj (#4532) * [7.x][DROOLS-7046] Migrate drools-test-coverage tests to assertj (#4538) * [DROOLS-7046] Migrate drools-test-coverage tests to assertj * [DROOLS-7046] Cleaning up remaing tests in drools-test-coverage * [DROOLS-7053] Migrate remaining tests to assertj (#4540)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces hamcrest with asserj in drools tests.
JIRA:
DROOLS-6917
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream