Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-6920] Fails to parse a constraint connected with OR with a bi… #4341

Merged
merged 2 commits into from
May 5, 2022

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Apr 27, 2022

…nd variable on right side in executable-model

Ports
This PR is for 7.x
for main -> https://github.com/kiegroup/drools/pull/4361

JIRA:
https://issues.redhat.com/browse/DROOLS-6920

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

…nd variable on right side in executable-model
@tkobayas
Copy link
Contributor Author

tkobayas commented Apr 27, 2022

@mariofusco Please review this PR. I confirmed that tests passed for drools-model and test-compiler-integration locally.

@tkobayas
Copy link
Contributor Author

CDB: Not likely related to this PR.

[2022-04-27T10:35:02.177Z] [ERROR] /home/jenkins/workspace/KIE/7.x/compile/drools-7.x.compile/bc/kiegroup_kie_wb_common/kie-wb-common-forms/kie-wb-common-dynamic-forms/kie-wb-common-dynamic-forms-client/src/main/java/org/kie/workbench/common/forms/dynamic/client/rendering/renderers/relations/multipleSubform/MultipleSubFormFieldRenderer.java:[34,1] Internal error in org.kie.workbench.common.forms.adf.processors.FieldRendererProcessorjava.lang.ExceptionInInitializerError
[2022-04-27T10:35:02.177Z]      at freemarker.ext.beans.ClassIntrospectorBuilder.<init>(ClassIntrospectorBuilder.java:73)
[2022-04-27T10:35:02.177Z]      at freemarker.ext.beans.BeansWrapperConfiguration.<init>(BeansWrapperConfiguration.java:94)
[2022-04-27T10:35:02.177Z]      at freemarker.template.DefaultObjectWrapperConfiguration.<init>(DefaultObjectWrapperConfiguration.java:40)
[2022-04-27T10:35:02.177Z]      at freemarker.template.DefaultObjectWrapper$1.<init>(DefaultObjectWrapper.java:118)
[2022-04-27T10:35:02.177Z]      at freemarker.template.DefaultObjectWrapper.<init>(DefaultObjectWrapper.java:118)
[2022-04-27T10:35:02.177Z]      at freemarker.template.DefaultObjectWrapper.<init>(DefaultObjectWrapper.java:87)
[2022-04-27T10:35:02.177Z]      at freemarker.template.DefaultObjectWrapper.<clinit>(DefaultObjectWrapper.java:67)
[2022-04-27T10:35:02.177Z]      at freemarker.template._TemplateAPI.<clinit>(_TemplateAPI.java:82)
[2022-04-27T10:35:02.177Z]      at freemarker.core.Configurable.<init>(Configurable.java:420)
[2022-04-27T10:35:02.177Z]      at freemarker.template.Configuration.<init>(Configuration.java:940)
[2022-04-27T10:35:02.177Z]      at org.kie.workbench.common.forms.adf.processors.TemplateWriter.writeTemplate(TemplateWriter.java:49)
[2022-04-27T10:35:02.177Z]      at org.kie.workbench.common.forms.adf.processors.FieldRendererProcessor.processWithExceptions(FieldRendererProcessor.java:105)
[2022-04-27T10:35:02.177Z]      at org.uberfire.annotations.processors.AbstractErrorAbsorbingProcessor.process(AbstractErrorAbsorbingProcessor.java:78)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.callProcessor(JavacProcessingEnvironment.java:985)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:901)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1227)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1340)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1258)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:936)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
[2022-04-27T10:35:02.177Z]      at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
[2022-04-27T10:35:02.177Z]      at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
[2022-04-27T10:35:02.177Z]      at org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1134)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:187)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
[2022-04-27T10:35:02.177Z]      at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[2022-04-27T10:35:02.177Z]      at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:205)
[2022-04-27T10:35:02.177Z]      at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:77)
[2022-04-27T10:35:02.177Z]      at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[2022-04-27T10:35:02.177Z]      at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[2022-04-27T10:35:02.177Z]      at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[2022-04-27T10:35:02.177Z]      at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[2022-04-27T10:35:02.177Z]      at java.base/java.lang.Thread.run(Thread.java:829)
[2022-04-27T10:35:02.177Z]   Caused by: java.lang.IllegalStateException: Couldn't init freemarker.ext.beans.DefaultMemberAccessPolicy instance
[2022-04-27T10:35:02.177Z]      at freemarker.ext.beans.DefaultMemberAccessPolicy.<init>(DefaultMemberAccessPolicy.java:156)
[2022-04-27T10:35:02.177Z]      at freemarker.ext.beans.DefaultMemberAccessPolicy.<clinit>(DefaultMemberAccessPolicy.java:47)
[2022-04-27T10:35:02.177Z]      ... 39 more
[2022-04-27T10:35:02.177Z]   Caused by: java.io.IOException: Stream closed
[2022-04-27T10:35:02.177Z]      at java.base/java.util.zip.InflaterInputStream.ensureOpen(InflaterInputStream.java:68)
[2022-04-27T10:35:02.177Z]      at java.base/java.util.zip.InflaterInputStream.read(InflaterInputStream.java:143)
[2022-04-27T10:35:02.177Z]      at java.base/java.io.FilterInputStream.read(FilterInputStream.java:133)
[2022-04-27T10:35:02.177Z]      at java.base/sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
[2022-04-27T10:35:02.177Z]      at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
[2022-04-27T10:35:02.177Z]      at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
[2022-04-27T10:35:02.177Z]      at java.base/java.io.InputStreamReader.read(InputStreamReader.java:181)
[2022-04-27T10:35:02.177Z]      at java.base/java.io.BufferedReader.fill(BufferedReader.java:161)
[2022-04-27T10:35:02.177Z]      at java.base/java.io.BufferedReader.readLine(BufferedReader.java:326)
[2022-04-27T10:35:02.177Z]      at java.base/java.io.BufferedReader.readLine(BufferedReader.java:392)
[2022-04-27T10:35:02.177Z]      at freemarker.ext.beans.DefaultMemberAccessPolicy.loadMemberSelectorFileLines(DefaultMemberAccessPolicy.java:167)
[2022-04-27T10:35:02.177Z]      at freemarker.ext.beans.DefaultMemberAccessPolicy.<init>(DefaultMemberAccessPolicy.java:73)
[2022-04-27T10:35:02.177Z]      ... 40 more

@tkobayas
Copy link
Contributor Author

Jenkins run cdb

@tkobayas
Copy link
Contributor Author

Jenkins retest this

@tkobayas
Copy link
Contributor Author

tkobayas commented May 2, 2022

Linux - Compile Downstream Build : Tests were successful. Seemed to just fail to update the github status.

Finished: SUCCESS

@mariofusco mariofusco merged commit cf7a042 into apache:7.x May 5, 2022
tkobayas added a commit to tkobayas/drools that referenced this pull request May 6, 2022
apache#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
tkobayas added a commit to tkobayas/drools that referenced this pull request May 6, 2022
apache#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
mariofusco pushed a commit that referenced this pull request May 9, 2022
#4341) (#4361)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
evacchi added a commit to evacchi/drools that referenced this pull request May 9, 2022
commit f289879
Author: Mario Fusco <mario.fusco@gmail.com>
Date:   Mon May 9 13:48:07 2022 +0200

    [DROOLS-6944] remove duplicated drools-codegen-common dependency in drools bom (apache#4368)

commit 6f1de15
Author: Mario Fusco <mario.fusco@gmail.com>
Date:   Mon May 9 12:19:29 2022 +0200

    [DROOLS-6158] fix MapConstraintTest with executable model (apache#4366)

    * [DROOLS-6158] fix MapConstraintTest with executable model

    * [DROOLS-6599] fix executable model generation for nested maps

commit a436999
Author: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
Date:   Mon May 9 16:15:35 2022 +0900

    [DROOLS-6920] Fails to parse a constraint connected with OR with a bi… (apache#4341) (apache#4361)

    * [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

    * - Additional test

commit 39a960a
Author: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
Date:   Mon May 9 16:15:25 2022 +0900

    [DROOLS-6596] Negative BigDecimalLiteral in mvel dialect causes ClassCastException (apache#4351) (apache#4360)

commit 9bc0bd5
Author: PGG <2699243+alwinlin23@users.noreply.github.com>
Date:   Sun May 8 15:16:42 2022 +0800

    HelloWordExample needs drools-xml-support (apache#4350)

    Co-authored-by: alwin.linx <alwin.linx@alibaba-inc.com>

commit 17088e6
Author: Mario Fusco <mario.fusco@gmail.com>
Date:   Fri May 6 17:52:35 2022 +0200

    [DROOLS-6942] remove useless interfaces from spi package (apache#4359)

    * [DROOLS-6942] remove useless interfaces from spi package

    * wip

    * wip

commit 050c36f
Author: Tristan Radisson <tradisso@redhat.com>
Date:   Fri May 6 16:27:46 2022 +0200

    KOGITO-7110 Correct nightly DSL generation (apache#4364)

commit 85732a5
Author: Yeser Amer <yamer@redhat.com>
Date:   Fri May 6 14:07:40 2022 +0200

    Fixing selenium integration tests in `dmn-feel-gwt-showcase` (apache#4362)

    * Fixing selenium integration tests

    * Fixing selenium integration tests
tkobayas added a commit to tkobayas/drools that referenced this pull request Jul 21, 2022
apache#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
tkobayas added a commit to tkobayas/drools that referenced this pull request Jul 21, 2022
apache#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
mariofusco pushed a commit that referenced this pull request Jul 25, 2022
#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
tkobayas added a commit to tkobayas/drools that referenced this pull request Jul 25, 2022
apache#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
mariofusco pushed a commit that referenced this pull request Jul 25, 2022
#4341)

* [DROOLS-6920] Fails to parse a constraint connected with OR with a bind variable on right side in executable-model

* - Additional test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants