[7.x] [RHPAM-4504] Update KeyStoreHelper signature fails on ibm1.8 jdk cert… #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Sep 6, 2022
Comment on lines
242
to
247
| result = sig.verify(signature); // IBM JDK 1.8 returns false without SignatureException | ||
| } catch (SignatureException e) { | ||
| if (allowVerifyOldSignAlgo) { | ||
| // Fallback for old sign algorithm | ||
| sig = Signature.getInstance(MD5WITH_RSA); | ||
| sig.initVerify(cert.getPublicKey()); | ||
| sig.update(data); | ||
| return sig.verify(signature); | ||
| } else { | ||
| throw new RuntimeException("Failed to verify signature. If you call this method for data signed by old Drools version," + | ||
| " set system property \"" + KeyStoreConstants.PROP_VERIFY_OLD_SIGN + "\" to true" , e); | ||
| } | ||
| logger.warn("Exception while verifying signature", e); | ||
| return verifyWithFallbackAlgorithmIfAllowed(cert, data, signature); | ||
| } | ||
| return result || verifyWithFallbackAlgorithmIfAllowed(cert, data, signature); |
There was a problem hiding this comment.
IBM JDK 1.8 returns false without SignatureException. So let it retry with fallback algorithm in both cases -- false and SignatureException.
mariofusco
reviewed
Sep 6, 2022
| " set system property \"" + KeyStoreConstants.PROP_VERIFY_OLD_SIGN + "\" to true" , e); | ||
| } | ||
| logger.warn("Exception while verifying signature", e); | ||
| return verifyWithFallbackAlgorithmIfAllowed(cert, data, signature); |
There was a problem hiding this comment.
Minor improvement: I think that you can explicitly set result to false where declared and completely eliminate this early return statement. The other return at the end of the method should already cover all possible cases.
There was a problem hiding this comment.
Thank you, @mariofusco . It's exactly better!
hellowdan
approved these changes
Sep 6, 2022
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Sep 12, 2022
…k cert… (apache#4662) * [RHPAM-4504] Update KeyStoreHelper signature fails on ibm1.8 jdk certification test * - better writing
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Dec 15, 2022
…k cert… (apache#4662) * [RHPAM-4504] Update KeyStoreHelper signature fails on ibm1.8 jdk certification test * - better writing
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Dec 15, 2022
…k cert… (apache#4662) * [RHPAM-4504] Update KeyStoreHelper signature fails on ibm1.8 jdk certification test * - better writing
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Dec 16, 2022
…bm1.8 jdk cert… (apache#4662)" This reverts commit 17377b2.
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Dec 16, 2022
…bm1.8 jdk cert… (apache#4662) (apache#4872)" This reverts commit 0f78d65.
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Dec 16, 2022
…bm1.8 jdk cert… (apache#4662) (apache#4873)" This reverts commit 74fa069.
mariofusco
pushed a commit
that referenced
this pull request
Dec 16, 2022
mariofusco
pushed a commit
that referenced
this pull request
Dec 16, 2022
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Jan 24, 2023
…k cert… (apache#4662) (apache#4872) * [RHPAM-4504] Update KeyStoreHelper signature fails on ibm1.8 jdk certification test * - better writing
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Jan 24, 2023
…k cert… (apache#4662) (apache#4873) * [RHPAM-4504] Update KeyStoreHelper signature fails on ibm1.8 jdk certification test * - better writing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ification test
Ports
This PR is for 7.x.
Will do for 7.67.x
Will do for 7.67.x-blue
for main -> https://github.com/kiegroup/drools/pull/4678
JIRA:
https://issues.redhat.com/browse/RHPAM-4504
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for mandrel checks
Run native checks against Mandrel image
Please add comment: Jenkins run mandrel
for a specific mandrel check
Run native checks against Mandrel image
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] mandrel