Split Beta Nodes #5787 #5788
Open
Split Beta Nodes #5787 #5788
+2,288
−1,921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5788 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/display/redirect Test results:
Those are the test failures: org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testAddRemoveFacts[KieBase type=CLOUD_IDENTITY]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian2[KieBase type=CLOUD_IDENTITY]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRianWithFire[KieBase type=CLOUD_IDENTITY]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testRemoveRuleWithSharedRia[KieBase type=CLOUD_IDENTITY]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testReaddRulesSharedRianDoubleNots[KieBase type=CLOUD_IDENTITY]class org.drools.core.reteoo.NotRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.NotRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian[KieBase type=CLOUD_IDENTITY]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testAddRemoveFacts[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian2[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRianWithFire[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testRemoveRuleWithSharedRia[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testReaddRulesSharedRianDoubleNots[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]class org.drools.core.reteoo.NotRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.NotRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app') |
|
Hi Mark, let's please merge this after we release Apache 10. |
Yes that's fine. |
mariofusco
reviewed
Mar 18, 2024
| @@ -201,9 +201,9 @@ public void removeTerminalNode(RuleRemovalContext context, TerminalNode tn, Coll | |||
|
|
|||
| private Collection<BaseNode> removeNodes(AbstractTerminalNode terminalNode, Collection<InternalWorkingMemory> wms, RuleRemovalContext context) { | |||
| Map<Integer, BaseNode> stillInUse = new HashMap<>(); | |||
| Collection<ObjectSource> alphas = new HashSet<>(); | |||
| Collection<ObjectSource> alphas = new ArrayList<>(); | |||
There was a problem hiding this comment.
We used a Set here to be sure of not traversing and processing the same nodes more than once, are you sure that there are no longer duplication and it is now save to use a List instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes in the issue #5787
#5787
I am not looking to merge this yet; still working on cleaning up the code and changing the names of classes.