[incubator-kie-drools#5706] Grouped accessors for nested objects broken #5790
Conversation
| public class ParserStringUtils { | ||
| public class Antlr4ParserStringUtils { |
There was a problem hiding this comment.
Renamed because this PR introduces ParserStringUtils which is used by both antlr3 an antlr4 parsers.
| * Append a prefix to a grouped constraint. | ||
| * Even if the constraint contains || and/or &&, append the prefix to each element. | ||
| */ | ||
| public static String appendPrefix(String prefix, String expr) { |
There was a problem hiding this comment.
I moved this method from DRL6Parser (antlr3 based), because this logic is pure String manipulation. And this is used by both antlr3 based DRL6Parser and antlr4 based DRLVisitorImpl.
DRLVisitorImpl might be able to implement this in another way using more visit methods, but it would likely be complex than this method, so I decided to reuse this method.
|
Fixed Before PR After PR |
|
@yurloc @mariofusco @gitgabrio Please review, thanks! |
drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java
Outdated
Show resolved
Hide resolved
...rl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java
Show resolved
Hide resolved
…er/antlr4/DRLVisitorImpl.java Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
…l/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
|
@yurloc Ahh, thank you very much for the suggestions! |
|
Fixing progress: There were 408 failed tests (-2). |
Issue:
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.