Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-5920] [new-parser] Strict annotation parsing #5976

Merged

Conversation

tkobayas
Copy link
Contributor

  • Skip the test for new parser

Issue:

@tkobayas
Copy link
Contributor Author

tkobayas commented May 31, 2024

LanguageLevelOption.DRL6_STRICT has 2 points:

  1. Parser phase: Annotation should be placed at the beginning of the statement. e.g.
@Xyz rule yyy
when
  ...
  1. Compiler phase: Annotation should be resolved as Java annotation (= custom annotation java class has to actually exist).

LanguageLevelOption.DRL6_STRICT is not written in document and I haven't seen users using it. Also implementing it would cause complexity which doesn't likely pay off (Old parser maintains 2 parser classes DRL6Parser and DRL6StrictParser). So I think we can skip the test at the moment, and we will discuss a deprecation plan in dev@kie.apache.org later. Of course, if there is a strong need, we will be able to implement it. WDYT? @mariofusco @yurloc @gitgabrio @baldimir

@mariofusco mariofusco merged commit e79e36e into apache:dev-new-parser Jun 4, 2024
0 of 4 checks passed
tkobayas added a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants