[KOGITO-9218] - Update SonataFlowPlatform struct #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
ricardozanini
requested review from
kaldesai,
radtriste and
MarianMacik
as code owners
✅ Deploy Preview for tangerine-crostata-04a6bf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
|
@MarianMacik mind taking another look? I've added a migration guide for the operator since we are changing the YAML structure. |
kaldesai
reviewed
Aug 7, 2023
serverlessworkflow/modules/ROOT/pages/cloud/operator/build-and-deploy-workflows.adoc
Outdated
Show resolved
Hide resolved
kaldesai
reviewed
Aug 7, 2023
serverlessworkflow/modules/ROOT/pages/cloud/operator/migration-guide.adoc
Outdated
Show resolved
Hide resolved
kaldesai
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
@ricardozanini Minor suggestion. Otherwise, your content looks good to me. Thank you!
…-deploy-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
MarianMacik
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
@ricardozanini Changes look good after migration guide inclusion.
radtriste
approved these changes
Aug 7, 2023
|
@ricardozanini I added a card to the |
|
Thank you folks! I'm putting this on hold until we merge the operator's PR. |
ricardozanini
added
backport-1.42.x
and removed
DO_NOT_MERGE 🙅
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
* [KOGITO-9218] - Update SonataFlowPlatform struct Signed-off-by: Ricardo Zanini <zanini@redhat.com> * Adding migration guide for 1.43.0 Signed-off-by: Ricardo Zanini <zanini@redhat.com> * Update serverlessworkflow/modules/ROOT/pages/cloud/operator/build-and-deploy-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com> * Update index.adoc --------- Signed-off-by: Ricardo Zanini <zanini@redhat.com> Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
5 tasks
ricardozanini
added a commit
that referenced
this pull request
Aug 11, 2023
[KOGITO-9218] - Update SonataFlowPlatform struct (#427) * [KOGITO-9218] - Update SonataFlowPlatform struct * Adding migration guide for 1.43.0 * Update serverlessworkflow/modules/ROOT/pages/cloud/operator/build-and-deploy-workflows.adoc * Apply suggestions from code review * Update index.adoc --------- Signed-off-by: Ricardo Zanini <zanini@redhat.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://issues.redhat.com/browse/KOGITO-9218
Description:
Follow up on the changes on:
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject[0.9.x] KOGITO-XYZ SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.