Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-kogito-docs-554: Guide to help DB Admins to understand Serverless Workflows persistence #555

Merged
merged 13 commits into from Mar 4, 2024

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Feb 28, 2024

Closes #554

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Contributor

@nmirasch nmirasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've added some suggestions, feel free to take that into account!

@wmedvede
Copy link
Contributor Author

closes #555

wmedvede and others added 6 commits February 28, 2024 19:15
…oper-use-cases/persistence/persistence-core-concepts.adoc

Co-authored-by: nmirasch <neus.miras@gmail.com>
…oper-use-cases/persistence/persistence-core-concepts.adoc

Co-authored-by: nmirasch <neus.miras@gmail.com>
…oper-use-cases/persistence/persistence-core-concepts.adoc

Co-authored-by: nmirasch <neus.miras@gmail.com>
…oper-use-cases/persistence/postgresql-advanced-concepts.adoc

Co-authored-by: nmirasch <neus.miras@gmail.com>
…oper-use-cases/persistence/postgresql-advanced-concepts.adoc

Co-authored-by: nmirasch <neus.miras@gmail.com>
…oper-use-cases/persistence/postgresql-advanced-concepts.adoc

Co-authored-by: nmirasch <neus.miras@gmail.com>
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks :)

wmedvede and others added 3 commits February 29, 2024 10:19
…oper-use-cases/persistence/persistence-core-concepts.adoc

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
…oper-use-cases/persistence/persistence-core-concepts.adoc

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
…oper-use-cases/persistence/persistence-core-concepts.adoc

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
@ricardozanini
Copy link
Member

@kaldesai can you please take a look? 🙏

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have very minor comments. Otherwise, your content looks very good to me :) Very well written! Thank you!

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome guide, thanks @wmedvede

wmedvede and others added 3 commits March 4, 2024 10:44
…oper-use-cases/persistence/postgresql-advanced-concepts.adoc

Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…oper-use-cases/persistence/postgresql-advanced-concepts.adoc

Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…oper-use-cases/persistence/postgresql-advanced-concepts.adoc

Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
@ricardozanini ricardozanini merged commit 35ccd49 into apache:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guide to help DB Admins to understand Serverless Workflows persistence
5 participants