Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-583: Holistic review of non-quarkus getting-started chapter #651

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

LuboTerifaj
Copy link
Contributor

Closes/Fixes/Resolves #583

Holistic review of non-quarkus getting-started chapter

The PR updates some issues found during the chapter review.

There were identified the following issues that are out of the scope of this PR:

Copy link
Contributor

🎊 PR Preview 2ff9d5e has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-651.surge.sh

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Why are the linked issues out of scope please?

@LuboTerifaj
Copy link
Contributor Author

Hello @domhanak ,

the fixing the "out of scope" issues may take more time to finish.

The goal of the #583 was to identify the issues and report them for the documentation team.

This PR fixes some parts that were easily fixable without a big impact on the whole documentation structure, so they are ready for the following release.

@LuboTerifaj
Copy link
Contributor Author

fyi @kaldesai

@ricardozanini ricardozanini merged commit 6dd7577 into apache:main Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holistic review of non-quarkus getting-started chapter
3 participants