Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-3903 DMN Submarine endpoint codegen #71

Merged
merged 18 commits into from
Aug 27, 2019

Conversation

tarilabs
Copy link
Member

"}")
.contentType(ContentType.JSON)
.when()
.post("/Traffic Violation")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pertinent DMN REST resources is now generated ad-hoc for the model, and the model name is Traffic Violation

@Test
public void testEvaluateTrafficViolation() {
given()
.body("{\n" +
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atm the payload is not typed, ref. roadmap.

@tarilabs
Copy link
Member Author

doesn't Jenkins here pick up the same branch name on the kogito-runtimes?
(see linked PR)

@tarilabs
Copy link
Member Author

I am getting

[ERROR]   TrafficViolationTest.testEvaluateTrafficViolation:49 1 expectation failed.
Expected status code <200> but was <405>.

which makes me wonder if this Jenkins instance allows me to perform rest tests?

@mswiderski
Copy link
Contributor

@tarilabs yes, you can use rest tests in Jenkins without issues, see this one that runs on each build
https://github.com/kiegroup/kogito-examples/blob/master/jbpm-quarkus-example/src/test/java/org/kie/kogito/examples/OrdersRestTest.java

@tarilabs
Copy link
Member Author

weird, as it works locally just fine, only on Jenkins I get a 405 ?

@tarilabs
Copy link
Member Author

image

@tarilabs
Copy link
Member Author

could be Jenkins did not reckon the old name of my fork. I updated my forks name, let's see if that solves..

@tarilabs
Copy link
Member Author

that solved.

@evacchi evacchi merged commit 7239709 into apache:master Aug 27, 2019
@tarilabs
Copy link
Member Author

this was CI based on https://github.com/kiegroup/kogito-runtimes/pull/125 as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants