Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRVLOGIC-158] - Dynamic resources script is reading wrong container … #1676

Merged
merged 2 commits into from
Aug 31, 2023
Merged

[SRVLOGIC-158] - Dynamic resources script is reading wrong container … #1676

merged 2 commits into from
Aug 31, 2023

Conversation

spolti
Copy link
Member

@spolti spolti commented Aug 23, 2023

…sys files on cgroupsv2

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:

  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this

  • Prod tests
    Please add comment: Jenkins (re)run [prod|Prod|PROD]

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@spolti spolti force-pushed the SRVLOGIC-158 branch 2 times, most recently from f09168f to 8a6f930 Compare August 23, 2023 18:43
@spolti
[SRVLOGIC-158] - Dynamic resources script is reading wrong container …
d81a574 
…sys files on cgroupsv2

Signed-off-by: Spolti <fspolti@redhat.com>
@ricardozanini ricardozanini self-requested a review August 23, 2023 19:16
@kie-ci1
Copy link

kie-ci1 commented Aug 23, 2023

PR job #1037 was: UNSTABLE
Possible explanation: This should be test failures

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1037/display/redirect
See console log:

Console Logs [Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-task-console: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-management-console: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1037/api/json
[Pipeline] readJSON
[Pipeline] sh

@kie-ci1
Copy link

kie-ci1 commented Aug 23, 2023

PR job #1039 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1039/display/redirect
See console log:

Console Logs [Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-management-console: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1039/api/json
[Pipeline] readJSON
[Pipeline] sh

@kie-ci1
Copy link

kie-ci1 commented Aug 23, 2023

PR job #1040 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1040/display/redirect
See console log:

Console Logs [Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-trusty-ui: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-task-console: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1040/api/json
[Pipeline] readJSON
[Pipeline] sh

@kie-ci1
Copy link

kie-ci1 commented Aug 23, 2023

PR job #1041 was: UNSTABLE
Possible explanation: This should be test failures

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1041/display/redirect
See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-task-console: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-swf-devmode: https://github.com/kiegroup/kogito-images/pull/1676 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1676 - kogito-s2i-builder: https://github.com/kiegroup/kogito-images/pull/1676 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-s2i-builder seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1041/api/json
[Pipeline] readJSON
[Pipeline] sh

@spolti
Copy link
Member Author

spolti commented Aug 24, 2023

CI issues are not related.

radtriste
radtriste reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one small comment. Gonna test it on my machine which is cgroups v2

tests/test-apps/clone-repo.sh Show resolved Hide resolved
@radtriste
Copy link
Contributor

jenkins retest this

@kie-ci1
Copy link

kie-ci1 commented Aug 31, 2023

PR job #1052 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1052/display/redirect
See console log:

Console Logs
-------------------------------------------------------------
[ERROR] Can't merge source into Target. Please rebase PR branch.
-------------------------------------------------------------
Source: git://github.com/spolti/kogito-images SRVLOGIC-158
Target: bb14cd2 [KOGITO-9749] - Add Events Process, Process Management, and Sources addon to builder image (#1678)
-------------------------------------------------------------

[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Validate CeKit Image and Modules descriptors)
Stage "Validate CeKit Image and Modules descriptors" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Build & Test Images)
Stage "Build & Test Images" skipped due to earlier failure(s)
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] echo
[INFO] Clean workspace
[Pipeline] cleanWs
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] done
[Pipeline] echo
[INFO] Workspace cleaned
[Pipeline] echo
[INFO] Cleanup Maven artifacts
[Pipeline] sh
+ rm -rf /home/jenkins/.m2/repository
[Pipeline] echo
[INFO] .m2/repository cleaned
[Pipeline] }
[Pipeline] // script
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images/1052/api/json
[Pipeline] readJSON
[Pipeline] sh

@radtriste
Copy link
Contributor

Tested all good on cgroup v2 system

@spolti
Copy link
Member Author

spolti commented Aug 31, 2023

Thanks @radtriste

@ricardozanini
Copy link
Member

Can we merge this?

@radtriste radtriste merged commit ba0879e into apache:main Aug 31, 2023
28 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@spolti @radtriste
[SRVLOGIC-158] - Dynamic resources script is reading wrong container …
346b107 
…sys files on cgroupsv2 (#1676)

Signed-off-by: Spolti <fspolti@redhat.com>
Co-authored-by: radtriste <tradisso@redhat.com>
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Closed
8 tasks
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@spolti @radtriste
[SRVLOGIC-158] - Dynamic resources script is reading wrong container …
ca4973a 
…sys files on cgroupsv2 (#1676)

Signed-off-by: Spolti <fspolti@redhat.com>
Co-authored-by: radtriste <tradisso@redhat.com>
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Closed
8 tasks
@spolti spolti deleted the SRVLOGIC-158 branch August 31, 2023 14:05
@kie-ci1 kie-ci1 mentioned this pull request Sep 1, 2023
Merged
8 tasks
@jmtd jmtd mentioned this pull request Sep 15, 2023
Merged
7 tasks
spolti added a commit to spolti/incubator-kie-kogito-images that referenced this pull request Sep 27, 2023
@spolti @radtriste
[1.13.x-next][SRVLOGIC-158] - Dynamic resources script is reading wro…
02bf16c 
…ng container sys files on cgroupsv2 (apache#1676)

Signed-off-by: Spolti <fspolti@redhat.com>
Co-authored-by: radtriste <tradisso@redhat.com>
rgdoliveira pushed a commit to kiegroup/kogito-images that referenced this pull request Dec 11, 2023
@spolti @radtriste
[1.13.x-blue-next][SRVLOGIC-158] - Dynamic resources script is readin…
0ebec74 
…g wrong container sys files on cgroupsv2 (apache#1676)

Signed-off-by: Spolti <fspolti@redhat.com>
Co-authored-by: radtriste <tradisso@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidesalerno davidesalerno davidesalerno approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

@radtriste radtriste radtriste approved these changes

Assignees
No one assigned
Labels
backport-1.13.x-blue-next backport-1.13.x-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spolti @kie-ci1 @radtriste @ricardozanini @davidesalerno