Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-242] Adding CLI delete service and project feature #50

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Sep 9, 2019

See:
https://issues.jboss.org/browse/KOGITO-242

In this PR:

  1. Added CLI kogito delete-service NAME [flags] feature, which will delete a specified service
  2. Added CLI kogito delete-project NAME feature, which will delete a specified project

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@ricardozanini ricardozanini added the WIP 👷‍♂️ Pull Request is on work in progress label Sep 9, 2019
@ricardozanini ricardozanini removed the WIP 👷‍♂️ Pull Request is on work in progress label Sep 9, 2019
Copy link
Contributor

@xieshenzh xieshenzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ricardozanini . The code looks good. But it is confusing that we use new-app to create a project and delete-project to delete a project. And maybe, we can use one command delete to delete both project and service, just like how kubectl and oc work. WDYT?

@ricardozanini
Copy link
Member Author

Thanks, @ricardozanini . The code looks good. But it is confusing that we use new-app to create a project and delete-project to delete a project. And maybe, we can use one command delete to delete both project and service, just like how kubectl and oc work. WDYT?

Hi @xiezhang7! Thanks for reviewing it. Yes, we'll change the new-app command to new-project:
#52

I'm just waiting for this to get merged to continue the work there.

We agreed in the https://issues.jboss.org/browse/KOGITO-248 to call delete-service and delete-project to perform those operations since service means something different in OCP. 😢

@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Sep 10, 2019
@ricardozanini ricardozanini merged commit bed9e89 into apache:master Sep 10, 2019
@ricardozanini ricardozanini deleted the kogito-242 branch September 10, 2019 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready 🚀 PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants