Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KOGITO-9810] Supporting nested properties #3229

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[KOGITO-9810] Supporting nested properties #3229

merged 4 commits into from
Oct 10, 2023

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Sep 14, 2023 •
edited

This adds support for nested properties when using $SECRET

@fjtirado fjtirado force-pushed the KOGITO-9810 branch 2 times, most recently from e23375c to edc8523 Compare September 15, 2023 15:27
@fjtirado
Copy link
Contributor Author

jenkins retest this

@fjtirado
Copy link
Contributor Author

jenkins run kogito-runtimes tests

ricardozanini
ricardozanini approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant.

tiagodolphine
tiagodolphine approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@tiagodolphine tiagodolphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjtirado
Copy link
Contributor Author

fjtirado commented Oct 6, 2023

jenkins retest this

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 6, 2023

PR job #7 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3229 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3229/7/display/redirect

Test results:

  • PASSED: 3386
  • FAILED: 2

Those are the test failures:

org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTest expected: not equal but was: <0>
org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest 1 expectation failed.
Expected status code <201> but was <400>.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 9, 2023

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3229 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3229/8/display/redirect

Test results:

  • PASSED: 3388
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest 1 expectation failed.
Expected status code <201> but was <400>.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 9, 2023

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3229 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/test/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3229/2/display/redirect

Test results:

  • PASSED: 2429
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest 1 expectation failed.
Expected status code <201> but was <400>.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 9, 2023

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3229 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/test/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3229/3/display/redirect

Test results:

  • PASSED: 3388
  • FAILED: 1

Those are the test failures:

org.kie.kogito.infinispan.health.InfinispanHealthCheckIT.testCall java.lang.reflect.InvocationTargetException

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 10, 2023

PR job #10 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3229 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3229/10/display/redirect

Test results:

  • PASSED: 3387
  • FAILED: 2

Those are the test failures:

org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTest expected: not equal but was: <0>
org.kie.kogito.quarkus.workflows.AsyncAPIIT.testConsumer Unexpected error in InitProducerIdResponse; The broker is not available.

@fjtirado fjtirado merged commit 0feb66e into apache:main Oct 10, 2023
1 of 6 checks passed
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Dec 13, 2023
@fjtirado @rgdoliveira
[KOGITO-9810] Supporting nested properties (apache#3229)
dfbd63a 
* [KOGITO-9810] Supporting nested properties

* Revert "[KOGITO-9810] Supporting nested properties"

This reverts commit 8df264f.

* [KOGITO-9810] Alternative approach

* [KOGITO-9810] Fixing image test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@tiagodolphine tiagodolphine tiagodolphine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fjtirado @kie-ci3 @ricardozanini @tiagodolphine