[KOGITO-9861] Fixing compilation issues with nested classes and arrays #3242
Conversation
fjtirado
changed the title
| @@ -48,10 +47,13 @@ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager manag | |||
| protected static <V> V buildBody(Map<String, Object> params, Class<V> clazz) { | |||
| for (Object obj : params.values()) { | |||
| if (obj != null && clazz.isAssignableFrom(obj.getClass())) { | |||
| logger.trace("Invoking workitemhandler with value {}", obj); | |||
There was a problem hiding this comment.
This change is not stricly needed for this PR, but I feel it isinteresting to have a trace here.
| return clazz.cast(obj); | ||
| } | ||
| } | ||
| return ObjectMapperFactory.get().convertValue(params, clazz); | ||
| V value = JsonObjectUtils.convertValue(params, clazz); | ||
| logger.trace("Invoking workitemhandler with value {}", value); |
There was a problem hiding this comment.
Same here. Also, in some circumstances, JsonObjectUtils.converValue will be faster than directly invoking Jackson converter
|
|
||
| private String fromDotName(DotName dotName) { | ||
| String result = dotName.toString(); | ||
| if (dotName.isInner()) { |
There was a problem hiding this comment.
Supporting inner classes, it is really unfortunate that DotName.toString use Class.getName rather than Class.getCanonicalName, forcing us to add this code to replace the $
| return parseClassOrInterfaceType(param.asParameterizedType().name().toString()) | ||
| .setTypeArguments(NodeList.nodeList(param.asParameterizedType().arguments().stream().map(this::fromClass).collect(Collectors.toList()))); | ||
| ClassOrInterfaceType result = parseClassOrInterfaceType(fromDotName(param.asParameterizedType().name())); | ||
| if (includeGeneric) { |
There was a problem hiding this comment.
And this is basically the fix (rest of clasess on this PR are for testing), we do not want to include generic when the ClassExpr is not used for casting. Since the caller knows the usage, an extra boolean parameter was added to the method
|
Thank you for the quick fix :) 🐎 |
apache#3242) * [KOGITO-9861] Fixing compilation issues with nested and arrays * [KOGITO-9861] Adding IT test
Fix a problem that prevents using arrays as open api body request (top level, inner ones were already supported)
Also fixes compilation issues when open api extension generate pojos as inner classes