incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` #3401

pefernan · 2024-02-12T17:17:03Z

ricardozanini

Added the keyword workflow where matters. So this PR is just for the metainfo? 'cause we might need to also change the name accordingly to the spreadsheet: https://docs.google.com/spreadsheets/u/1/d/1gsttRcXGtwGQO469EYFDhLxJLEA7Kl3gmioR6XhGhjY/edit#gid=0

quarkus/addons/events/process/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/knative/eventing/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/jobs/messaging/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/jobs/management/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/jobs/knative-eventing/runtime/src/main/resources/META-INF/quarkus-extension.yaml

...kus/addons/persistence/postgresql/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/persistence/rocksdb/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/process-management/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/process-svg/runtime/src/main/resources/META-INF/quarkus-extension.yaml

...s/kogito-quarkus-extension/kogito-quarkus/src/main/resources/META-INF/quarkus-extension.yaml

pefernan · 2024-02-13T08:51:45Z

@ricardozanini yes, this is only metadata review. I think the rename should happen after release

elguardian

LGTM. thx for the good work Pere and keeps things strict to the scope of the task !

pefernan · 2024-02-14T17:19:08Z

@ricardozanini just updated the PR aligning the capabilities and the extensions metadata with the new namings, so we can proceed with the rename with extensions in shape.

ricardozanini

lgtm

kie-ci3 · 2024-02-14T20:08:36Z

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/5/display/redirect

Test results:

PASSED: 3229
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

quarkus/addons/source-files/runtime/src/main/resources/META-INF/quarkus-extension.yaml

...kus/addons/persistence/filesystem/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/process-definitions/runtime/src/main/resources/META-INF/quarkus-extension.yaml

quarkus/addons/tracing-decision/runtime/src/main/resources/META-INF/quarkus-extension.yaml

...ions-extension/kogito-quarkus-predictions/src/main/resources/META-INF/quarkus-extension.yaml

...cesses-extension/kogito-quarkus-processes/src/main/resources/META-INF/quarkus-extension.yaml

...ions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/pom.xml

elguardian

some minor comments to explain

kie-ci3 · 2024-02-15T11:17:27Z

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/8/display/redirect

Test results:

PASSED: 3229
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

pefernan · 2024-02-15T12:08:11Z

Build failures apparently related to quarkusio/quarkus#20777

kie-ci3 · 2024-02-15T15:38:57Z

PR job #15 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/15/display/redirect

Test results:

PASSED: 2353
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

elguardian

LGTM

kie-ci3 · 2024-02-15T20:06:44Z

PR job #18 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/18/display/redirect

Test results:

PASSED: 3229
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

kie-ci3 · 2024-02-16T08:58:01Z

PR job #19 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/19/display/redirect

Test results:

PASSED: 2325
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

kie-ci3 · 2024-02-16T10:29:40Z

PR job #20 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/20/display/redirect

Test results:

PASSED: 2881
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

kie-ci3 · 2024-02-19T10:36:27Z

PR job #25 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/25/display/redirect

Test results:

PASSED: 3229
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

…to-runtimes`

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

- Quarkus Extensions it-tests fix

kie-ci3 · 2024-02-19T15:35:46Z

PR job #26 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/26/display/redirect

Test results:

PASSED: 3229
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

ricardozanini · 2024-02-19T18:06:40Z

@pefernan why are we having this many failures in the checks, do you know?

EDIT: nvm, I saw your message on Zulip

pefernan · 2024-02-19T18:29:34Z

@ricardozanini yea, what's happening is that I changed the capabilities Id's but quarkus is still resolving the old deployment artifacts for our quarkus extensions instead of using the artifacts from .m2, making it tests fail when our extensions check the capabilities. I'm pretty sure that this errors won't happen as soon as we publish the new extension artifacts with the new capability id's. In the worst scenario I'll rollback the capability id's to the previous value, but sooner or later we may have to face this rename, so I think it's better now than later.

kie-ci3 · 2024-02-19T22:05:25Z

PR job #28 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3401 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3401/28/display/redirect

Test results:

PASSED: 3229
FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.ServerlessWorkflowCodestartTest.buildAllProjectsForLocalUse

[Run project return status is zero]
expected: 0
but was: 1

…to-runtimes` (apache#3401) * incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` * Apply suggestions from code review Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> * - added `kogito-addon-quarkus-source-files` extension metadata. * - Aligned metadata & capabilities to new naming * - fix typo * - adding `cloud` category - Quarkus Extensions it-tests fix * - cleanup --------- Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

pefernan requested review from ricardozanini, elguardian and porcelli February 12, 2024 17:17

ricardozanini reviewed Feb 12, 2024

View reviewed changes

elguardian approved these changes Feb 13, 2024

View reviewed changes

ricardozanini approved these changes Feb 14, 2024

View reviewed changes

elguardian reviewed Feb 15, 2024

View reviewed changes

quarkus/addons/source-files/runtime/src/main/resources/META-INF/quarkus-extension.yaml Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

quarkus/addons/source-files/runtime/src/main/resources/META-INF/quarkus-extension.yaml Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

...kus/addons/persistence/filesystem/runtime/src/main/resources/META-INF/quarkus-extension.yaml Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

quarkus/addons/process-definitions/runtime/src/main/resources/META-INF/quarkus-extension.yaml Outdated Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

quarkus/addons/tracing-decision/runtime/src/main/resources/META-INF/quarkus-extension.yaml Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

...ions-extension/kogito-quarkus-predictions/src/main/resources/META-INF/quarkus-extension.yaml Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

...cesses-extension/kogito-quarkus-processes/src/main/resources/META-INF/quarkus-extension.yaml Show resolved Hide resolved

elguardian reviewed Feb 15, 2024

View reviewed changes

...ions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/pom.xml Show resolved Hide resolved

elguardian requested changes Feb 15, 2024

View reviewed changes

pefernan force-pushed the incubator-kie-issues#917 branch 2 times, most recently from 2916074 to 8ed50a4 Compare February 15, 2024 11:14

pefernan force-pushed the incubator-kie-issues#917 branch from 1a8e651 to 7683c15 Compare February 15, 2024 14:23

apache deleted a comment from kie-ci3 Feb 15, 2024

pefernan force-pushed the incubator-kie-issues#917 branch from 7683c15 to d1eeda2 Compare February 15, 2024 15:37

pefernan force-pushed the incubator-kie-issues#917 branch from d1eeda2 to 660ac79 Compare February 15, 2024 16:08

elguardian self-requested a review February 15, 2024 16:44

elguardian approved these changes Feb 15, 2024

View reviewed changes

pefernan mentioned this pull request Feb 15, 2024

[WIP] incubator-kie-issues#917: Verify Quarkus Extensions metadata in kogito-runtimes apache/incubator-kie-kogito-apps#1987

Closed

7 tasks

pefernan force-pushed the incubator-kie-issues#917 branch from 8587c62 to 6cfd454 Compare February 16, 2024 08:56

pefernan force-pushed the incubator-kie-issues#917 branch 2 times, most recently from ff3f534 to c29d30b Compare February 19, 2024 08:43

pefernan and others added 7 commits February 19, 2024 15:22

incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogi…

8312613

…to-runtimes`

Apply suggestions from code review

17f0d5c

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

Apply suggestions from code review

ada8104

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

- added kogito-addon-quarkus-source-files extension metadata.

274d4bf

- Aligned metadata & capabilities to new naming

14445eb

- fix typo

d4ff4a4

- adding cloud category

468262d

- Quarkus Extensions it-tests fix

pefernan force-pushed the incubator-kie-issues#917 branch from 45d60d1 to 6b01cbf Compare February 19, 2024 16:30

- cleanup

5635f24

pefernan force-pushed the incubator-kie-issues#917 branch from 6b01cbf to 5635f24 Compare February 19, 2024 16:33

pefernan merged commit 0d51eeb into apache:main Feb 19, 2024
0 of 6 checks passed

domhanak mentioned this pull request Feb 20, 2024

[apache-ci] nightly native build-and-test job for kogito-apps fails on data-audit-quarkus-jpa-service apache/incubator-kie-kogito-apps#1992

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` #3401

incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` #3401

pefernan commented Feb 12, 2024 •

edited by elguardian

Loading

ricardozanini left a comment

pefernan commented Feb 13, 2024

elguardian left a comment

pefernan commented Feb 14, 2024

ricardozanini left a comment

kie-ci3 commented Feb 14, 2024

elguardian left a comment

kie-ci3 commented Feb 15, 2024

pefernan commented Feb 15, 2024

kie-ci3 commented Feb 15, 2024

elguardian left a comment

kie-ci3 commented Feb 15, 2024

kie-ci3 commented Feb 16, 2024

kie-ci3 commented Feb 16, 2024

kie-ci3 commented Feb 19, 2024

kie-ci3 commented Feb 19, 2024

ricardozanini commented Feb 19, 2024 •

edited

Loading

pefernan commented Feb 19, 2024

kie-ci3 commented Feb 19, 2024

incubator-kie-issues#917: Verify Quarkus Extensions metadata in kogito-runtimes #3401

incubator-kie-issues#917: Verify Quarkus Extensions metadata in kogito-runtimes #3401

Conversation

pefernan commented Feb 12, 2024 • edited by elguardian Loading

ricardozanini left a comment

Choose a reason for hiding this comment

pefernan commented Feb 13, 2024

elguardian left a comment

Choose a reason for hiding this comment

pefernan commented Feb 14, 2024

ricardozanini left a comment

Choose a reason for hiding this comment

kie-ci3 commented Feb 14, 2024

elguardian left a comment

Choose a reason for hiding this comment

kie-ci3 commented Feb 15, 2024

pefernan commented Feb 15, 2024

kie-ci3 commented Feb 15, 2024

elguardian left a comment

Choose a reason for hiding this comment

kie-ci3 commented Feb 15, 2024

kie-ci3 commented Feb 16, 2024

kie-ci3 commented Feb 16, 2024

kie-ci3 commented Feb 19, 2024

kie-ci3 commented Feb 19, 2024

ricardozanini commented Feb 19, 2024 • edited Loading

pefernan commented Feb 19, 2024

kie-ci3 commented Feb 19, 2024

incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` #3401

incubator-kie-issues#917: Verify Quarkus Extensions metadata in `kogito-runtimes` #3401

pefernan commented Feb 12, 2024 •

edited by elguardian

Loading

ricardozanini commented Feb 19, 2024 •

edited

Loading