Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-9819: [Operator image builder] Persistence not working in the image produced by operator generated image #261

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Sep 21, 2023

- Fixes the parameters construction for the kaniko builder which produced the issue.

Description of the change:
When testing the tuning of the sonataflow-operator-builder-config Docker file, it was detected that introduced ARGs where not processed well at the time of producing the kaniko --build-param's for the kaniko image build.
This change fixes these parameters processing.

Motivation for the change:
https://issues.redhat.com/browse/KOGITO-9819

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…image produced by operator generated image

    - Fixes the parameters construction for the kaniko builder which produced the issue.
@ricardozanini ricardozanini merged commit 5ef630e into apache:main Sep 21, 2023
7 checks passed
MarianMacik pushed a commit to MarianMacik/kogito-serverless-operator that referenced this pull request Sep 22, 2023
…image produced by operator generated image (apache#261)

- Fixes the parameters construction for the kaniko builder which produced the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants