Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-9856: [Operator] Operator calculated kogito.service.url don't have protocol #270

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Oct 2, 2023

- Adds the missing protocol.
- Introduces the ability to have set of properties that the operator generates by default,
  but the user has the chance to override with their own values if needed.

Description of the change:

Motivation for the change:

https://issues.redhat.com/browse/KOGITO-9856

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…have protocol

    - Adds the missing protocol.
    - Introduces the ability to have set of properties that the operator generates by default,
      but the user has the chance to override with their own values if needed.
@wmedvede wmedvede changed the title KOGITO-9856: [Operator] Operator calculated don't have protocol KOGITO-9856: [Operator] Operator calculated kogito.service.url don't have protocol Oct 2, 2023
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :D

@ricardozanini ricardozanini merged commit 6c70c4c into apache:main Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants