Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-9890] Generate safe volume naming based on DNS 1035 #272

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

ricardozanini
Copy link
Member

Description of the change:
In this PR, we safely generate volume naming for the dev profile resources to avoid problems with mount paths like META-INF/resources.

Motivation for the change:
See https://issues.redhat.com/browse/KOGITO-9890

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Copy link
Contributor

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a silly question .

@ricardozanini ricardozanini merged commit a7a158f into apache:main Oct 13, 2023
4 checks passed
@ricardozanini ricardozanini deleted the kogito-9890 branch October 13, 2023 14:15
ricardozanini added a commit to ricardozanini/incubator-kie-kogito-serverless-operator that referenced this pull request Nov 1, 2023
* [KOGITO-9890] Generate safe volume naming based on DNS 1035

Signed-off-by: Ricardo Zanini <zanini@redhat.com>

* Remove flacky test, and unused function

Signed-off-by: Ricardo Zanini <zanini@redhat.com>

---------

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants